Skip to content

Swift: Filter more clang options not recognized by off-the-shelf clang #21992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jketema merged 2 commits into from
Jun 17, 2026
+5 −1
Merged

Swift: Filter more clang options not recognized by off-the-shelf clang #21992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef67311
Swift: Filter more clang options not recognized by off-the-shelf clang
jketema Jun 16, 2026
2eb9c54
Swift: Update test to ensure stabilitry across Xcode versions
jketema Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion swift/ql/integration-tests/osx/hello-xcode/Files.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import swift

from File f
where exists(f.getRelativePath()) or f instanceof UnknownFile
where
(exists(f.getRelativePath()) or f instanceof UnknownFile) and
not f.getBaseName() = "<module-includes>"

@geoffw0 geoffw0 Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here?

@jketema jketema Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now start to extract additional files, some of which are called <module-includes> (these seem to be internal to the compiler). To keep the test results consistent across the three Xcode versions we run this test with, I'm filtering this out (only shows up with Xcode 26; not the earlier versions).

select f
2 changes: 2 additions & 0 deletions swift/tools/tracing-config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ function RegisterExtractorPack(id)
strip_unsupported_arg(args, '-experimental-skip-non-inlinable-function-bodies-without-types', 0)
strip_unsupported_clang_arg(args, '-ivfsstatcache', 1)
strip_unsupported_clang_arg(args, '-fno-odr-hash-protocols', 0)
strip_unsupported_clang_arg(args, '-fobjc-msgsend-selector-stubs', 0)
strip_unsupported_clang_arg(args, '-fstack-check', 0)
strip_unsupported_clang_arg(args, '-clang-vendor-feature=+disableNonDependentMemberExprInCurrentInstantiation', 0)
strip_unsupported_clang_arg(args, '-clang-vendor-feature=+enableAggressiveVLAFolding', 0)
strip_unsupported_clang_arg(args, '-clang-vendor-feature=+revert09abecef7bbf', 0)
Expand Down
Loading