Align qlref inline-expectation conversion with recipe for ql tests#21967
Draft
Copilot wants to merge 10 commits into
Draft
Align qlref inline-expectation conversion with recipe for ql tests#21967Copilot wants to merge 10 commits into
Copilot wants to merge 10 commits into
Conversation
Copilot
AI
changed the title
[WIP] Convert CodeQL queries for supported languages
Normalize non-Go/Java Jun 10, 2026
.qlref files to explicit query: format
Copilot
AI
changed the title
Normalize non-Go/Java
Convert non-Go/Java qlref tests to inline expectation tests via postprocess
Jun 10, 2026
.qlref files to explicit query: format
github-actions
Bot
added
C#
JS
C++
Python
Ruby
Rust
Contributor
|
Rerun has been triggered, but no failed runs found |
owen-mc
force-pushed
the
copilot/conversion-of-codeql-queries
branch
from
aa3982d to
4d2e16e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Copilot
AI
changed the title
Convert non-Go/Java qlref tests to inline expectation tests via postprocess
Align qlref inline-expectation conversion with recipe for ql tests
Jun 11, 2026
github-actions
Bot
added
documentation
QL-for-QL
and removed
Actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the branch to follow the agreed
.qlrefconversion recipe: convert eligible@kind problem/@kind path-problemtests to inline expectations, keep generated.expectedfiles untouched, and avoid out-of-scope languages/fixtures. The main change is adding the missingql/ql/test/queriescoverage and backing out prior work that violated the conversion boundaries.qltest coverage.qlreftests underql/ql/test/queries/{bugs,overlay,performance,style}to useutils/test/InlineExpectationsTestQuery.ql.$ Alertmarkers to the owned QL test sources at the existing expected-result end lines..expectedfiles unchanged for zero-result tests.Recipe conformance
.qlreffiles.QlRefInlineExpectationscases unchanged:PrintAst.qlref,Test4.qlref).qlrefYAML (QlRefInlineExpectations.qlref), where inline source comments are not the right ownership boundaryOut-of-scope cleanup
actionsinline-expectation conversion work, per the updated scope..expectededits and unrelated source/schema changes that were not part of the.qlrefconversion recipe.Example of the converted shape:
Original prompt
Created from VS Code.