Skip to content

Java: convert all qlref tests to inline expectation tests using postprocessing #21966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Java: convert all qlref tests to inline expectation tests using postprocessing #21966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c1d264
First pass converting qlref tests to inline expectation with postprocess
owen-mc Jun 10, 2026
3693185
Second pass
owen-mc Jun 10, 2026
a375e18
Third pass
owen-mc Jun 11, 2026
a4bf2b8
Fix 3 tests
owen-mc Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion ...sts/kotlin/all-platforms/gradle_kotlinx_serialization/ConstantExpAppearsNonConstant.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
query: Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion .../test-kotlin1/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
query: Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/AutoBoxing/AutoBoxing.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/legacy/AutoBoxing.ql
query: Violations of Best Practice/legacy/AutoBoxing.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/CloseReader/CloseReader.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Resource Leaks/CloseReader.ql
query: Likely Bugs/Resource Leaks/CloseReader.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/CloseWriter/CloseWriter.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Resource Leaks/CloseWriter.ql
query: Likely Bugs/Resource Leaks/CloseWriter.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/ConfusingOverloading/ConfusingOverloading.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
query: Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
6 changes: 3 additions & 3 deletions java/ql/test-kotlin1/query-tests/ConstantLoopCondition/A.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ fun fn0(f: Function0<Unit>) = f()

fun fn1() {
var c = true
while (c) { // TODO: false positive
while (c) { // $ SPURIOUS: Alert // TODO: false positive
fn0 {
c = false
}
}

var d = true
while (d) {
while (d) { // $ Alert
fn0 {
println(d)
}
}

val e = true
while (e) {
while (e) { // $ Alert
fn0 {
println(e)
}
Expand Down
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/ConstantLoopCondition/ConstantLoopCondition.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Termination/ConstantLoopCondition.ql
query: Likely Bugs/Termination/ConstantLoopCondition.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/DeadCode/DeadClass.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/DeadClass.ql
query: DeadCode/DeadClass.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/DeadCode/DeadMethod.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/DeadMethod.ql
query: DeadCode/DeadMethod.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion java/ql/test-kotlin1/query-tests/DeadRefTypes/DeadRefTypes.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
| test.kt:1:1:1:20 | C1 | Unused class: C1 is not referenced within this codebase. If not used as an external API it should be removed. |
| test.kt:1:1:1:31 | C1 | Unused class: C1 is not referenced within this codebase. If not used as an external API it should be removed. |
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/DeadRefTypes/DeadRefTypes.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Dead Code/DeadRefTypes.ql
query: Violations of Best Practice/Dead Code/DeadRefTypes.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion java/ql/test-kotlin1/query-tests/DeadRefTypes/test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
private class C1 { }
private class C1 { } // $ Alert

private class C2 { }

Expand Down
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/EmptyBlock/EmptyBlock.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/EmptyBlock.ql
query: Likely Bugs/Statements/EmptyBlock.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/ExposeRepresentation/ExposeRepresentation.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
query: Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/InnerClassCouldBeStatic/InnerClassCouldBeStatic.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Performance/InnerClassCouldBeStatic.ql
query: Performance/InnerClassCouldBeStatic.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/MissingInstanceofInEquals/MissingInstanceofInEquals.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Comparison/MissingInstanceofInEquals.ql
query: Likely Bugs/Comparison/MissingInstanceofInEquals.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/MissingOverrideAnnotation/MissingOverrideAnnotation.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Declarations/MissingOverrideAnnotation.ql
query: Advisory/Declarations/MissingOverrideAnnotation.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/MutualDependency/MutualDependency.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Architecture/Dependencies/MutualDependency.ql
query: Architecture/Dependencies/MutualDependency.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion .../ql/test-kotlin1/query-tests/NamingConventionsRefTypes/NamingConventionsRefTypes.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
| Test.kt:12:1:12:13 | aaaa | Class and interface names should start in uppercase. |
| Test.kt:12:1:12:24 | aaaa | Class and interface names should start in uppercase. |
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/NamingConventionsRefTypes/NamingConventionsRefTypes.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Naming/NamingConventionsRefTypes.ql
query: Advisory/Naming/NamingConventionsRefTypes.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion java/ql/test-kotlin1/query-tests/NamingConventionsRefTypes/Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ class Foo {
}
}

class aaaa {}
class aaaa {} // $ Alert
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/NonSerializableField/NonSerializableField.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Serialization/NonSerializableField.ql
query: Likely Bugs/Serialization/NonSerializableField.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Serialization/NonSerializableInnerClass.ql
query: Likely Bugs/Serialization/NonSerializableInnerClass.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/NullMaybe/NullMaybe.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Nullness/NullMaybe.ql
query: Likely Bugs/Nullness/NullMaybe.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/OneStatementPerLine/OneStatementPerLine.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Statements/OneStatementPerLine.ql
query: Advisory/Statements/OneStatementPerLine.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/PartiallyMaskedCatch/PartiallyMaskedCatch.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/PartiallyMaskedCatch.ql
query: Likely Bugs/Statements/PartiallyMaskedCatch.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/ReturnValueIgnored/ReturnValueIgnored.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/ReturnValueIgnored.ql
query: Likely Bugs/Statements/ReturnValueIgnored.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/SimplifyBoolExpr/SimplifyBoolExpr.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Boolean Logic/SimplifyBoolExpr.ql
query: Violations of Best Practice/Boolean Logic/SimplifyBoolExpr.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/UnderscoreIdentifier/UnderscoreIdentifier.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Compatibility/JDK9/UnderscoreIdentifier.ql
query: Compatibility/JDK9/UnderscoreIdentifier.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/UnreadLocal/UnreadLocal.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Dead Code/UnreadLocal.ql
query: Violations of Best Practice/Dead Code/UnreadLocal.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
4 changes: 2 additions & 2 deletions java/ql/test-kotlin1/query-tests/UnreadLocal/test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ fun fn0(size: Int) {
}

fun fn1(a: Array<Int>) {
for (e in a) {
for (e in a) { // $ Alert
println()
}
}

fun fn2(a: Array<Int>) {
for ((idx, e) in a.withIndex()) {
for ((idx, e) in a.withIndex()) { // $ Alert
println()
}
}
Expand Down
2 changes: 1 addition & 1 deletion java/ql/test-kotlin1/query-tests/UselessNullCheck/Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fun fn(x:Any?, y: Any?) {

fun fn0(o: Any?) {
if (o != null) {
o?.toString()
o?.toString() // $ Alert
o.toString()
}
}
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/UselessNullCheck/UselessNullCheck.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Language Abuse/UselessNullCheck.ql
query: Language Abuse/UselessNullCheck.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin1/query-tests/UselessParameter/UselessParameter.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/UselessParameter.ql
query: DeadCode/UselessParameter.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion ...kotlin1/query-tests/WhitespaceContradictsPrecedence/WhitespaceContradictsPrecedence.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
query: Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion .../test-kotlin2/query-tests/AbstractToConcreteCollection/AbstractToConcreteCollection.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
query: Violations of Best Practice/Implementation Hiding/AbstractToConcreteCollection.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/AutoBoxing/AutoBoxing.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/legacy/AutoBoxing.ql
query: Violations of Best Practice/legacy/AutoBoxing.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/CloseReader/CloseReader.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Resource Leaks/CloseReader.ql
query: Likely Bugs/Resource Leaks/CloseReader.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/CloseWriter/CloseWriter.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Resource Leaks/CloseWriter.ql
query: Likely Bugs/Resource Leaks/CloseWriter.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/ConfusingOverloading/ConfusingOverloading.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
query: Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
6 changes: 3 additions & 3 deletions java/ql/test-kotlin2/query-tests/ConstantLoopCondition/A.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,21 @@ fun fn0(f: Function0<Unit>) = f()

fun fn1() {
var c = true
while (c) { // TODO: false positive
while (c) { // $ SPURIOUS: Alert // TODO: false positive
fn0 {
c = false
}
}

var d = true
while (d) {
while (d) { // $ Alert
fn0 {
println(d)
}
}

val e = true
while (e) {
while (e) { // $ Alert
fn0 {
println(e)
}
Expand Down
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/ConstantLoopCondition/ConstantLoopCondition.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Termination/ConstantLoopCondition.ql
query: Likely Bugs/Termination/ConstantLoopCondition.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/DeadCode/DeadClass.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/DeadClass.ql
query: DeadCode/DeadClass.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/DeadCode/DeadMethod.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/DeadMethod.ql
query: DeadCode/DeadMethod.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/DeadRefTypes/DeadRefTypes.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Dead Code/DeadRefTypes.ql
query: Violations of Best Practice/Dead Code/DeadRefTypes.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion java/ql/test-kotlin2/query-tests/DeadRefTypes/test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
private class C1 { }
private class C1 { } // $ Alert

private class C2 { }

Expand Down
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/EmptyBlock/EmptyBlock.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/EmptyBlock.ql
query: Likely Bugs/Statements/EmptyBlock.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/ExposeRepresentation/ExposeRepresentation.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
query: Violations of Best Practice/Implementation Hiding/ExposeRepresentation.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/InnerClassCouldBeStatic/InnerClassCouldBeStatic.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Performance/InnerClassCouldBeStatic.ql
query: Performance/InnerClassCouldBeStatic.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/MissingInstanceofInEquals/MissingInstanceofInEquals.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Comparison/MissingInstanceofInEquals.ql
query: Likely Bugs/Comparison/MissingInstanceofInEquals.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/MissingOverrideAnnotation/MissingOverrideAnnotation.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Declarations/MissingOverrideAnnotation.ql
query: Advisory/Declarations/MissingOverrideAnnotation.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/MutualDependency/MutualDependency.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Architecture/Dependencies/MutualDependency.ql
query: Architecture/Dependencies/MutualDependency.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/NamingConventionsRefTypes/NamingConventionsRefTypes.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Naming/NamingConventionsRefTypes.ql
query: Advisory/Naming/NamingConventionsRefTypes.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
2 changes: 1 addition & 1 deletion java/ql/test-kotlin2/query-tests/NamingConventionsRefTypes/Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ class Foo {
}
}

class aaaa {}
class aaaa {} // $ Alert
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/NonSerializableField/NonSerializableField.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Serialization/NonSerializableField.ql
query: Likely Bugs/Serialization/NonSerializableField.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/NonSerializableInnerClass/NonSerializableInnerClass.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Serialization/NonSerializableInnerClass.ql
query: Likely Bugs/Serialization/NonSerializableInnerClass.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/NullMaybe/NullMaybe.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Nullness/NullMaybe.ql
query: Likely Bugs/Nullness/NullMaybe.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/OneStatementPerLine/OneStatementPerLine.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Advisory/Statements/OneStatementPerLine.ql
query: Advisory/Statements/OneStatementPerLine.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/PartiallyMaskedCatch/PartiallyMaskedCatch.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/PartiallyMaskedCatch.ql
query: Likely Bugs/Statements/PartiallyMaskedCatch.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/ReturnValueIgnored/ReturnValueIgnored.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Statements/ReturnValueIgnored.ql
query: Likely Bugs/Statements/ReturnValueIgnored.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/SimplifyBoolExpr/SimplifyBoolExpr.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Boolean Logic/SimplifyBoolExpr.ql
query: Violations of Best Practice/Boolean Logic/SimplifyBoolExpr.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/UnderscoreIdentifier/UnderscoreIdentifier.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Compatibility/JDK9/UnderscoreIdentifier.ql
query: Compatibility/JDK9/UnderscoreIdentifier.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/UnreadLocal/UnreadLocal.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Violations of Best Practice/Dead Code/UnreadLocal.ql
query: Violations of Best Practice/Dead Code/UnreadLocal.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
4 changes: 2 additions & 2 deletions java/ql/test-kotlin2/query-tests/UnreadLocal/test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ fun fn0(size: Int) {
}

fun fn1(a: Array<Int>) {
for (e in a) {
for (e in a) { // $ Alert
println()
}
}

fun fn2(a: Array<Int>) {
for ((idx, e) in a.withIndex()) {
for ((idx, e) in a.withIndex()) { // $ Alert
println()
}
}
Expand Down
2 changes: 1 addition & 1 deletion java/ql/test-kotlin2/query-tests/UselessNullCheck/Test.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ fun fn(x:Any?, y: Any?) {
fun fn0(o: Any?) {
if (o != null) {
o?.toString()
o.toString()
o.toString() // $ Alert
}
}
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/UselessNullCheck/UselessNullCheck.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Language Abuse/UselessNullCheck.ql
query: Language Abuse/UselessNullCheck.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion java/ql/test-kotlin2/query-tests/UselessParameter/UselessParameter.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
DeadCode/UselessParameter.ql
query: DeadCode/UselessParameter.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
3 changes: 2 additions & 1 deletion ...kotlin2/query-tests/WhitespaceContradictsPrecedence/WhitespaceContradictsPrecedence.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
query: Likely Bugs/Arithmetic/WhitespaceContradictsPrecedence.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
4 changes: 3 additions & 1 deletion java/ql/test/experimental/query-tests/quantum/examples/NonceReuse/NonceReuse.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
query: experimental/quantum/Examples/ReusedNonce.ql
postprocess: utils/test/PrettyPrintModels.ql
postprocess:
- utils/test/PrettyPrintModels.ql
- utils/test/InlineExpectationsTestQuery.ql
Loading
Loading