Go: migrate control flow graph to shared CFG library - #21614

Closed

owen-mc with Copilot wants to merge 79 commits into

mainfrom

copilot/vscode-mndb17m3-9fpv

Commits on Jul 9, 2026

Initial plan

Copilot
authored and
owen-mc
committed
6f93a71
Incidental fix to `CaseClause.getAnExpr()`
owen-mc
committed
2a3be26

Commits on Jul 10, 2026

Initial shared CFG library instantiation for Go
owen-mc
committed
d79920c
Add go/print-cfg
owen-mc
committed
f8b0c11
Create cfg node for child of ParenExpr
owen-mc
committed
718dad4
Model non-returning functions in CFG
owen-mc
committed
e319654
Tweak `getEnclosingCallable`
owen-mc
committed
d603cd4
Fix edges to function exit with result variables
owen-mc
committed
137db51
Do not include comments in the CFG
owen-mc
committed
7a58784
Use shared CFG implementation of for loops
owen-mc
committed
a6931e3
Fix CFG for select statements
owen-mc
committed
e7927d2
Fix CFG for range loop
owen-mc
committed
3436e6c
Include receivers in parameter init
owen-mc
committed
d488b32
Fix global value numbering calculation
owen-mc
committed
cbad545
Produce CFG nodes for more reference expressions, like selector bases
owen-mc
committed
56dc936
Fix CFG for return instructions
owen-mc
committed
15ed3ba
Control flow shouldn't enter another callable
owen-mc
committed
6284acc
Fix empty switch statements
owen-mc
committed
433722f
Accept change in test output
owen-mc
committed
9d12edb
Restore `ExprNode` for `FuncLit`
owen-mc
committed
73204db
update function-entry additional nodes
owen-mc
committed
cc47cef
Fix range loop CFG
owen-mc
committed
f9e25f6
Fix lit-init nodes
owen-mc
committed
e55eecf
Use shared CFG `getIfInit`
owen-mc
committed
740e3a0
Go: update expected node names
owen-mc
committed
e4cb405
Add Go CFG consistency query
owen-mc
committed
1f4bbe5
Fix treatment of `ParenExpr`
owen-mc
committed
d908e78
Restore `ConditionGuardNode`
owen-mc
committed
67b28d2
Accept test output change names
owen-mc
committed
9ee3ecc
Fix ConditionGuardNode
owen-mc
committed
94ccd7c
Fix CFG for expressionless switch statements
owen-mc
committed
819f076
Accept changes
owen-mc
committed
8154ed6
Include implicit type switch var in CFG
owen-mc
committed
2544cca
Allow overriding endAbruptCompletion for callables
owen-mc
committed
9a2f822
Shared CFG: add callableExitStep hook for routing epilogue tails to exit nodes
owen-mc
committed
bb5f601
Go CFG: anchor result-read epilogue on Normal Exit via new hooks
owen-mc
committed
5438846
Shared CFG: add hooks for reachability-gated exit epilogue
owen-mc
committed
0bca94f
Go CFG: run deferred calls at function exit in LIFO order
owen-mc
committed
a57367d
Fix calls for defer statements
owen-mc
committed
5d8a9e4
Update query for unreachable statements
owen-mc
committed
75a833c
Migrate Go expression switch CFG to shared library; handle fallthrough via fallsThrough

Copilot
authored and
owen-mc
committed
ba7527c
Fix switch-case sanitizer edge for shared CFG and accept CFG expected

Copilot
authored and
owen-mc
committed
6167003
Update SSA expected files for new shared-CFG node locations

Copilot
authored and
owen-mc
committed
e99ade7
Migrate Go type switches to shared CFG switch model (Option B)

Copilot
authored and
owen-mc
committed
6f15605
Small refactors
owen-mc
committed
0c0506e
Fix break in select statements
owen-mc
committed
7dfe573
Remove unused send instruction node
owen-mc
committed
0cb574f
Fix data flow through tuple extraction for f(g())
owen-mc
committed
cdbc19b
Fix defer logic for panics
owen-mc
committed
e444730
Include ResultZeroInitInstruction in EvalImplicitInitInstruction
owen-mc
committed
f730c88
Fix circular dependency
owen-mc
committed
4aaf735
Fix return edges
owen-mc
committed
80ee840
Fix ParenExpr consistency test failures
owen-mc
committed
107717d
Go: adopt ForeachStmt with destructuring
owen-mc
committed
832f844
Only make implicit varargs slice node for reachable calls
owen-mc
committed
a3b3381
Fix InitLiteralComponentInstruction.getRhs() for key-value pairs
owen-mc
committed
45ef413
Give KeyValueExpr a type and fix notype test
owen-mc
committed
dc8dbac
Test changes to be checked
owen-mc
committed
17deba8
Accept test result for improved GVN
owen-mc
committed
28bd631
Accept improved accuracy in redundant recover test
owen-mc
committed
dfb90b3
Accept test changes
owen-mc
committed
9236c3a
Accept consistency query output
owen-mc
committed
d9b3f00
Accept CFG changes
owen-mc
committed
b6136a1
Accept changes
owen-mc
committed
8d1fba3
Accept test result changes
owen-mc
committed
c08b03f
fold implicit-one operand into incdec-rhs instruction
owen-mc
committed
2bde73c
fold compound-assign write into the compound-rhs instruction
owen-mc
committed
c85744e
drop implicit slice-bound nodes
owen-mc
committed
27e86d8
Merge parameter 'arg' node into 'param-init'
owen-mc
committed
0c381d9
Merge 'result-init' node into 'result-zero-init'
owen-mc
committed
57951e2
Fold implicit literal element index into the lit-init node
owen-mc
committed
f07ab45
Remove redundant inConditionalContext
owen-mc
committed
01eabc8
Simplify postOrInOrder
owen-mc
committed
193cd99
Use default goto handling
owen-mc
committed
1c60ffa
Fold uninitialised var-decl zero-init and write into one node
owen-mc
committed
d30162b
Fold tuple-destructuring extract and write into one node
owen-mc
committed
c8f81bc
Unify result-zero-init and zero-init node kinds
owen-mc
committed
992a0b5

Commits on Jul 11, 2026

Simplify zero-init code after unifying result-zero-init
owen-mc
committed
6bb4aef
Unify incdec-rhs into the compound-rhs node kind
owen-mc
committed
8eaa86e