Skip to content

C#: Autoformat#1846

Merged
semmle-qlci merged 2 commits into
github:masterfrom
hvitved:csharp/autoformat
Sep 2, 2019
Merged

C#: Autoformat#1846
semmle-qlci merged 2 commits into
github:masterfrom
hvitved:csharp/autoformat

Conversation

@hvitved

@hvitved hvitved commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

For C#, we like to keep all our QL code auto-formatted. Since we now sync new IR files with C++, that means autoformatting them as well (just like we autoformat the shared dataflow implementation). I hope that is OK.

@hvitved hvitved requested review from a team as code owners August 30, 2019 07:56
@jbj

jbj commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

@dave-bartolomeo and @rdmarsh2, shout if this interferes with your open PRs or other ongoing work.

@rdmarsh2

Copy link
Copy Markdown
Contributor

I think we'll always have ongoing work that it could interfere with. I'd rather do it now rather than waiting around for a gap.

@hvitved hvitved removed the request for review from a team September 2, 2019 07:31
@semmle-qlci semmle-qlci merged commit 0cf872e into github:master Sep 2, 2019
@hvitved hvitved deleted the csharp/autoformat branch September 2, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants