Rust: try to speed things up a bit#17849
Merged
Merged
Conversation
Files were reloaded to handle cases were there was no content for a file_id, causing a panic. Missing contents was caused by files that did not contain valid UTF-8 data. These are skipped by rust-analyzer when it is loading data into the RootDatabase.
redsun82
reviewed
Oct 28, 2024
| WithDatabase { db: RootDatabase, vfs: Vfs }, | ||
| pub enum RustAnalyzer<'a> { | ||
| WithDatabase { | ||
| db: &'a RootDatabase, |
Contributor
There was a problem hiding this comment.
this is probably not needed any more, as it can be accessed via semantics.db
aibaars
force-pushed
the
aibaars/single-semantics
branch
from
7859e5f to
7792b5c
Compare
aibaars
force-pushed
the
aibaars/single-semantics
branch
from
7792b5c to
fa3bc06
Compare
If: * the text for a file_id is not found (likely non-utf data in file) * path does not appear in Vfs, in which case we fall back on loading the file from disk with no "semantics" available
aibaars
force-pushed
the
aibaars/single-semantics
branch
from
fa3bc06 to
0e511d6
Compare
redsun82
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.