Rust: Implement UnusedValue.ql
#17726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/unused-value
branch
from
82094c5 to
e622991
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** Same as `lastRefRedef`, but skips uncertain reads. */ | ||
| pragma[nomagic] | ||
| private predicate lastRefSkipUncertainReadsExt(DefinitionExt def, BasicBlock bb, int i) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter
hvitved
force-pushed
the
rust/unused-value
branch
from
e622991 to
d50d1b0
Compare
hvitved
force-pushed
the
rust/unused-value
branch
2 times, most recently
from
1165f83 to
548521b
Compare
geoffw0
reviewed
Oct 11, 2024
| } | ||
|
|
||
| use YesOrNo::{Yes, No}; // allows `Yes`, `No` to be accessed without qualifiers. | ||
| use YesOrNo::{No, Yes}; // allows `Yes`, `No` to be accessed without qualifiers. |
Contributor
Author
There was a problem hiding this comment.
Hmm, I think it's the auto-formatter.
Contributor
There was a problem hiding this comment.
In general I believe we should not autoformat test code in the target language. Autoformatting adds a regularity that could (theoretically) mask issues in the extractor.
Contributor
There was a problem hiding this comment.
Not that I strongly care about this particular case (reverting not necessary).
hvitved
force-pushed
the
rust/unused-value
branch
from
548521b to
b6a26b5
Compare
hvitved
force-pushed
the
rust/unused-value
branch
from
b6a26b5 to
118bbb1
Compare
Contributor
|
Oh, we should have a (successful) DCA run to check this query isn't too noisy (like |
Contributor
Contributor
Author
|
Superseded by #17773. |
Contributor
|
Thanks for the work you did on this (all merged now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an initial version of
UnusedValue.ql, based on SSA.