Skip to content

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 9, 2024

This PR adds an initial static single assignment (SSA) library to Rust.

In this first version, we restrict the analysis to variables that are either immutable, or mutable with the following constraints:

We may be able to relax these constraints, but that will be done follow-up.

@github-actions github-actions bot added C# Ruby Rust Pull requests that update Rust code Swift labels Oct 9, 2024

/** Same as `lastRefRedef`, but skips uncertain reads. */
pragma[nomagic]
private predicate lastRefSkipUncertainReadsExt(DefinitionExt def, BasicBlock bb, int i) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter

The QLDoc has no documentation for bb, or def, or i, but the QLDoc mentions lastRefRedef
@hvitved hvitved force-pushed the rust/ssa branch 8 times, most recently from ca73280 to 5215568 Compare October 10, 2024 11:40
@hvitved hvitved force-pushed the rust/ssa branch 3 times, most recently from 10c8fee to 6a792a4 Compare October 11, 2024 12:46
@hvitved hvitved marked this pull request as ready for review October 11, 2024 12:57
Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paldepind paldepind merged commit cc1e33f into github:main Oct 15, 2024
@hvitved hvitved deleted the rust/ssa branch October 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants