Swift: upgrade extractor to support Swift 5.8.1 #13458
Conversation
| # - name: Print unextracted entities | ||
| # shell: bash | ||
| # run: | | ||
| # bazel run //swift/extractor/print_unextracted |
There was a problem hiding this comment.
This is only used internally, and now it started failing due to some missing dylibs. We'll fix it later.
There was a problem hiding this comment.
I wonder if this still even works as expected, but agreed, we can look at it later
| - uses: swift-actions/setup-swift@65540b95f51493d65f5e59e97dcef9629ddf11bf | ||
| with: | ||
| swift-version: "${{steps.get_swift_version.outputs.version}}" | ||
| swift-version: "5.8" |
There was a problem hiding this comment.
setup-swift doesn't support 5.8.1 yet, and it seems there is no need to match the exact version anymore.
|
Where shall I put the change-note? 🤔 |
Good question. Extractor notes don't have an obvious place - I think you can either put it internally in the CLI changelog (which will go public with the release) or put it in the change notes for the Swift library pack in this PR. |
|
I think CLI changelog is a better place for such a change note. |
AlexDenisov
added
the
no-change-note-required
redsun82
left a comment
redsun82
left a comment
There was a problem hiding this comment.
Everything seems in order to me (but I'm co-author of half of the commits here 😅)
| # - name: Print unextracted entities | ||
| # shell: bash | ||
| # run: | | ||
| # bazel run //swift/extractor/print_unextracted |
There was a problem hiding this comment.
I wonder if this still even works as expected, but agreed, we can look at it later
|
|
||
| pkg_files( | ||
| name = "swift-test-sdk-arch", | ||
| srcs = ["//swift/third_party/swift-llvm-support:swift-test-sdk"], |
There was a problem hiding this comment.
Is the test-sdk still required? can't the resource-dir replace the need for the separate sdk? In case the answer is yes, this can probably wait the follow-up PRs
There was a problem hiding this comment.
I'm not 100% sure, so decided to keep it as is for now, Happy to look into it separately.
This PR adds preliminary support for Swift
5.8/5.8.1.