Skip to content

Swift: minimal 5.8 compatibility #12872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
redsun82 wants to merge 8 commits into from
Closed

Swift: minimal 5.8 compatibility #12872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8a7584
Swift: minimal 5.8 compatibility
redsun82 Apr 6, 2023
34fd78b
Swift: add upgrade/downgrade scripts
redsun82 Apr 19, 2023
2ebd4c6
Swift: remove print unextracted from action
redsun82 Apr 20, 2023
5324725
Swift: add 5.8 update QL test
redsun82 Apr 21, 2023
4e97f11
Swift: print only `toBeTested` errors in `Errors.ql` test
redsun82 Apr 24, 2023
eeb7985
Swift: accept `MethodLookupExpr` test results
redsun82 Apr 24, 2023
564c257
Swift: accept location change in `ConcreteFuncDecl_getParam.ql` test
redsun82 Apr 24, 2023
4ce141c
Swift: add clang ignored flag
redsun82 Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions swift/actions/build-and-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ runs:
mkdir -p bazel-cache/{repository,disk}
echo build --repository_cache=bazel-cache/repository --disk_cache=bazel-cache/disk > local.bazelrc
echo test --test_output=errors >> local.bazelrc
- name: Print unextracted entities
shell: bash
run: |
bazel run //swift/extractor/print_unextracted
- uses: ./swift/actions/share-extractor-pack
- name: Build Swift extractor
shell: bash
run: |
bazel run //swift:create-extractor-pack
- name: Print Swift extractor version
shell: bash
run: |
swift/extractor-pack/tools/*/extractor --version
- name: Run xcode-autobuilder tests
if : ${{ github.event_name == 'pull_request' && runner.os == 'macOS' }}
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion swift/actions/run-integration-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ runs:
- uses: actions/setup-python@v4
with:
python-version-file: 'swift/.python-version'
- uses: swift-actions/setup-swift@da0e3e04b5e3e15dbc3861bd835ad9f0afe56296
- uses: swift-actions/setup-swift@65540b95f51493d65f5e59e97dcef9629ddf11bf
with:
swift-version: "${{steps.get_swift_version.outputs.version}}"
- uses: ./.github/actions/fetch-codeql
Expand Down
36 changes: 36 additions & 0 deletions swift/downgrades/64d1b0a3d0c1ee70e8ae096b7ba73f9c7c49c929/downgrade.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
class Element extends @element {
string toString() { none() }
}

newtype TAddedUnspecifiedElement =
TNonClosureExprClosureBody(Element list, Element body) {
capture_list_exprs(list, body) and not closure_exprs(body)
}

module Fresh = QlBuiltins::NewEntity<TAddedUnspecifiedElement>;

class TNewElement = @element or Fresh::EntityId;

class NewElement extends TNewElement {
string toString() { none() }
}

query predicate new_unspecified_elements(NewElement u, string property, string error) {
unspecified_elements(u, property, error)
or
u = Fresh::map(TNonClosureExprClosureBody(_, _)) and
property = "closure_body" and
error = "while downgrading: closure_body not a @closure_expr"
}

query predicate new_unspecified_element_parents(NewElement u, Element parent) {
unspecified_element_parents(u, parent)
or
u = Fresh::map(TNonClosureExprClosureBody(parent, _))
}

query predicate new_capture_list_exprs(Element list, NewElement body) {
capture_list_exprs(list, body) and closure_exprs(body)
or
body = Fresh::map(TNonClosureExprClosureBody(list, _))
}
Loading