Skip to content

JS: Improved coverage for disabled certificate validation #12679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erik-krogh merged 3 commits into from
Mar 30, 2023
Merged

JS: Improved coverage for disabled certificate validation #12679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bf94e8
Added check to disabling certificate validation query
ctbellanti Mar 27, 2023
13c0eff
change to minor change
erik-krogh Mar 28, 2023
4778332
add test for https.createServer in DisablingCertificateValidation.ql
erik-krogh Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions javascript/ql/src/Security/CWE-295/DisablingCertificateValidation.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ DataFlow::InvokeNode tlsInvocation() {
or
result = DataFlow::moduleMember("https", "Agent").getAnInstantiation()
or
result = DataFlow::moduleMember("https", "createServer").getACall()
or
exists(DataFlow::NewNode new |
new = DataFlow::moduleMember("tls", "TLSSocket").getAnInstantiation()
|
Expand Down
4 changes: 4 additions & 0 deletions javascript/ql/src/change-notes/2023-03-27-disabling-certificate-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `DisablingCertificateValidation.ql` query has been updated to check `createServer` from `https` for disabled certificate validation.
1 change: 1 addition & 0 deletions javascript/ql/test/query-tests/Security/CWE-295/DisablingCertificateValidation.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
| tst.js:45:2:45:28 | rejectU ... !!false | Disabling certificate validation is strongly discouraged. |
| tst.js:48:2:48:26 | rejectU ... : !true | Disabling certificate validation is strongly discouraged. |
| tst.js:74:9:74:33 | rejectU ... : false | Disabling certificate validation is strongly discouraged. |
| tst.js:80:5:80:29 | rejectU ... : false | Disabling certificate validation is strongly discouraged. |
6 changes: 5 additions & 1 deletion javascript/ql/test/query-tests/Security/CWE-295/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,8 @@ function getSomeunsafeOptions() {
rejectUnauthorized: false // NOT OK
}
}
new https.Agent(getSomeunsafeOptions());
new https.Agent(getSomeunsafeOptions());

https.createServer({
rejectUnauthorized: false // NOT OK
});