JS: Improved coverage for disabled certificate validation#12679
Merged
erik-krogh merged 3 commits intoMar 30, 2023
Conversation
owen-mc
changed the title
erik-krogh
reviewed
Mar 28, 2023
erik-krogh
previously approved these changes
Mar 28, 2023
erik-krogh
left a comment
erik-krogh
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Thanks for the contribution ❤️
An evaluation (internal link) looks good.
No performance regression, and a new result (in a test file).
erik-krogh
approved these changes
Mar 30, 2023
Contributor
|
I wanted a test, so I pushed it to your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DisablingCertificateValidation.qlquery has been improved by checkingcreateServerfromhttpsfor disabled certificate validation.