Skip to content

Python: Rewrite type trackers - #10634

Merged
codeql-ci merged 2 commits into
github:mainfrom
yoff:python/rewrite-typetrackers
Sep 30, 2022
Merged

Python: Rewrite type trackers#10634
codeql-ci merged 2 commits into
github:mainfrom
yoff:python/rewrite-typetrackers

Conversation

@yoff

@yoff yoff commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

While looking through our existing custom type trackers, I found these two that we already have the means to rewrite.

we have the option to use `regex.getAValueReachingSink`
rather than `regex.asSink`, but it will likely be used as a
sink for data flow.
There are several other clean ups I would like to do in this file,
but this can wait until we promote the query.
@yoff yoff added the no-change-note-required This PR does not need a change note label Sep 29, 2022
@yoff
yoff requested a review from a team as a code owner September 29, 2022 18:34

@tausbn tausbn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@codeql-ci
codeql-ci merged commit b66e5c5 into github:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants