Java: Address review comments.

michaelnebel · michaelnebel · commit 37a21ec54832 · 2024-01-12T13:36:23.000+01:00
diff --git a/java/ql/src/utils/modelgenerator/internal/CaptureSummaryFlowQuery.qll b/java/ql/src/utils/modelgenerator/internal/CaptureSummaryFlowQuery.qll
@@ -73,8 +73,9 @@ string captureFlow(DataFlowTargetApi api) {
 }
 
 /**
- * Gets the neutral summary for `api`, if any.
- * A neutral model is generated, if there does not exist any summary model.
+ * Gets the neutral summary model for `api`, if any.
+ * A neutral summary model is generated, if we are not generating
+ * a summary model that applies to `api`.
  */
 string captureNoFlow(DataFlowTargetApi api) {
   not exists(DataFlowTargetApi api0 | exists(captureFlow(api0)) and api0.lift() = api.lift()) and
diff --git a/java/ql/test/utils/modelgenerator/dataflow/p/MultipleImpl2.java b/java/ql/test/utils/modelgenerator/dataflow/p/MultipleImpl2.java
@@ -2,6 +2,9 @@
 
 class MultipleImpl2 {
 
+    // Multiple implementations of the same interface.
+    // This is used to test that we only generate a summary model and
+    // not neutral summary model for `IInterface.m`.
     public interface IInterface {
         Object m(Object value);
     }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,9 @@`
`2`	`2`
`3`	`3`	`class MultipleImpl2 {`
`4`	`4`
	`5`	`+ // Multiple implementations of the same interface.`
	`6`	`+ // This is used to test that we only generate a summary model and`
	`7`	+ // not neutral summary model for `IInterface.m`.
`5`	`8`	`public interface IInterface {`
`6`	`9`	`Object m(Object value);`
`7`	`10`	`}`