Conversation
Contributor
Author
|
Ok, tests fail because a test app created with the |
levenleven
approved these changes
Jan 8, 2024
Contributor
levenleven
left a comment
levenleven
left a comment
There was a problem hiding this comment.
Looks good
Ok, tests fail because a test app created with the rails, "~> 6", but the lib code works with any version, validated locally
Let's add ~> 6 requirement and bump gem's major. No reason to support older versions I think as they are EOL
Contributor
Author
This will stick rails version to 6.*, so the lib won't work with projects which use rails 7.*. We have an issue with |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to set multiple base auth urls