Allow to customize the aria-label attribute of the results container#94
Merged
keithamus merged 2 commits intogithub:mainfrom Apr 21, 2023
brunoprietog:custom-results-aria-label
Merged
Allow to customize the aria-label attribute of the results container#94keithamus merged 2 commits intogithub:mainfrom brunoprietog:custom-results-aria-label
keithamus merged 2 commits intogithub:mainfrom
brunoprietog:custom-results-aria-label
Conversation
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
siddharthkp
approved these changes
Sep 28, 2022
Contributor
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Good catch!
👍 from primer-reviewers
Contributor
Author
|
Hi, what is missing so that this can be merged? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is not allowed to customize the aria-label attribute of the results container, since the constructor does not check if an aria-label exists before setting the generic aria-label.
Even if it is appropriate to set "results" in all cases, this prevents translating the labels to other languages.