Skip to content

[GHSA-9c47-m6qq-7p4h] Prototype Pollution in JSON5 via Parse Method - #1541

Merged
advisory-database[bot] merged 1 commit into
jordanbtucker/advisory-improvement-1541from
jordanbtucker-GHSA-9c47-m6qq-7p4h
Jan 3, 2023
Merged

advisory-database[bot] merged 1 commit into
jordanbtucker/advisory-improvement-1541from
jordanbtucker-GHSA-9c47-m6qq-7p4h

Conversation

@jordanbtucker

Copy link
Copy Markdown

Updates

  • Affected products
  • Description
  • References

Comments
Includes information about a backport for v1 and fixes a typo in the Mitigation section.

@github

github commented Dec 30, 2022

Copy link
Copy Markdown
Collaborator

Hi there @jdgregson and @jordanbtucker! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@ashkulz

ashkulz commented Dec 31, 2022

Copy link
Copy Markdown

Since @jordanbtucker already updated the project-specific advisory, shouldn't there be some sort of auto-sync in place (i.e. obviating the need for this PR)?

@jordanbtucker

Copy link
Copy Markdown
Author

@ashkulz Updates to the global advisory database need to be vetted by security professionals to ensure its quality and accuracy.

@pkuczynski

Copy link
Copy Markdown

@jordanbtucker out of the interest, how long it usually takes?

@ashkulz

ashkulz commented Jan 2, 2023

Copy link
Copy Markdown

I guess people are yet to come back from the holidays 🤷‍♂️

@gustaff-weldon

Copy link
Copy Markdown

Looking forward to getting this merged to remove false positives on 1.0.2 version we upgraded to.

@jordanbtucker

jordanbtucker commented Jan 2, 2023

Copy link
Copy Markdown
Author

I would look at previous PRs in this repo to get an idea of an ETA and current backlog.

@viceice

viceice commented Jan 3, 2023

Copy link
Copy Markdown

For me those fixes for 2.2.2 and 1.0.2 are pretty much the same 🤔

@advisory-database
advisory-database Bot merged this pull request into jordanbtucker/advisory-improvement-1541 Jan 3, 2023
@advisory-database
advisory-database Bot deleted the jordanbtucker-GHSA-9c47-m6qq-7p4h branch January 3, 2023 15:04
@advisory-database

Copy link
Copy Markdown
Contributor

Hi @jordanbtucker! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@tapasmitamishra25

Copy link
Copy Markdown

@jordanbtucker In our apps, we use json5@1.0.2, we still could see the vulnerability and its showing that it will be fixed in 2.2.2. so can you please help here by letting us know how long will it take to reflect in our apps or we need to change something from our end.
Thanks!

@eugene1g

eugene1g commented Jan 4, 2023

Copy link
Copy Markdown

@tapasmitamishra25 We also have json5@1.0.2 and our vulnerability scanner (trivy) stopped flagging that version. On some CI machine we had to update the scanner database for it to pick up the latest updates for this advisory, but I suspect this PR resolved the issue at the root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants