Repository navigation
[GHSA-6973-8887-87ff] nimiq-block has skip block quorum bypass via out-of-range BitSet indices & u16 truncation - #10658
Open
zuhairhalawa wants to merge 1 commit into
Conversation
Collaborator
|
Hi there @jsdanielh! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
Bot
changed the base branch from
main
to
zuhairhalawa/advisory-improvement-10658
October 25, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Sets the patched version to 1.3.0 and adds the fix commit d0205905 ("Fix quorum bypass via out-of-range BitSet signer indices" (PR #3657)). The commit is contained in the tag 1.3.0 and not in the previous release 1.2.2 (git tag --contains). v1.3.0 adds checked_signer_slots(), which rejects out-of-range BitSet indices; v1.2.2 skip_block.rs uses signers.len() and "slot as u16" without a range check. crates.io has no 1.3.0 (published versions: 0.0.0 to 0.2.0, then 1.7.2), so fixed 1.3.0 and fixed 1.7.2 are equivalent there; the repository tags v1.0.0 to v1.2.2 are vulnerable as well.