This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Consolidating PullRequestStatusCircle change handlers #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
approved these changes
Feb 1, 2019
Contributor
grokys
left a comment
grokys
left a comment
There was a problem hiding this comment.
Ah yes, that looks better!
jcansdale
approved these changes
Feb 4, 2019
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Nice bit of simplification. 🎈 LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some conversation with @grokys I learned that I was using the change handlers incorrectly. I assumed the handler's purpose was to set the value on the instance, but I realize that the method is called after the value is already set on the instance. That allows the methods to be simpler.
Related to : #2145