This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use custom UIContext to load GitHubPackage / PullRequestStatusBarPackage in context of active repo #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make GitHubPackage auto-load on backgroundLoad thread.
This was referenced Mar 2, 2018
shana
previously approved these changes
Mar 2, 2018
Contributor
shana
left a comment
shana
left a comment
There was a problem hiding this comment.
This is awesome, great job!
We no longer need to use `IVSGitExt` to initialize the PR status bar when there is an active Git repository.
We must await InitializeMenus to ensure that menus are ready. SwitchToMainThreadAsync doesn't exit until a solution has loaded.
jcansdale
force-pushed
the
fixes/1511-Git-UIContext
branch
from
94bce3d to
d951127
Compare
9 tasks
jcansdale
changed the title
jcansdale
changed the base branch from
refactor/convert-VSGitExt-to-service
to
feature/show-current-pr
shana
approved these changes
Mar 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1396
This PR does the following:
Guids.UIContext_Gitwhich is activated when a repository is activePullRequestStatusBarPackageto auto-load onUIContext_GitGitHubPackageto auto-load onUIContext_GitGitHubPackagecompletes menu initializationFixes #1511