This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Allow inline comment peek view to resize to content. #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jcansdale
approved these changes
Aug 4, 2017
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
This is definitely working better than before. 👍
Can be a bit glitchy with over-sized comment lists (when the top of the peek view goes off screen), but I understand this could be tricky to fix. It's certainly an improvement for most cases.
I like how it handles the comment box being expanded as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the inline comment peek view to size itself according to the amount of content in the thread.
It also fixes the scrolling issue we previously had with the peek view where scrollwheel messages weren't passed up to the editor when the peek view was fully scrolled.