Added information to help newcomers get allowed#138
Merged
dscho merged 2 commits intogitgitgadget:masterfrom Oct 28, 2019
Merged
Added information to help newcomers get allowed#138dscho merged 2 commits intogitgitgadget:masterfrom
dscho merged 2 commits intogitgitgadget:masterfrom
Conversation
Member
|
What about looking at other, recent GitGitGadget PRs where somebody |
dscho
reviewed
Oct 25, 2019
logiclrd
force-pushed
the
GettingAllowedHint
branch
2 times, most recently
from
833539d to
76deda5
Compare
Added text to the "Contributing the patches" section that provides a couple of options for finding other allowed users who can /allow you for GitGitGadget, including a reference to the #git-devel IRC channel.
logiclrd
force-pushed
the
GettingAllowedHint
branch
from
76deda5 to
07ea41c
Compare
Contributor
Author
|
I have incorporated that suggestion and squashed everything down to one commit. :-) |
webstech
reviewed
Oct 25, 2019
nasamuffin
reviewed
Oct 25, 2019
Contributor
nasamuffin
left a comment
nasamuffin
left a comment
There was a problem hiding this comment.
Nice, it looks good to me. I think between these two things it should be sufficient and a contributor wouldn't need to email the list to ask - especially dscho's suggestion helps guarantee you will get someone who's been recently active on the project. Thanks for the contribution, logiclrd.
webstech
reviewed
Oct 26, 2019
@webstech (GitHub) pointed out that /allow can be used without specifying a username, in which case the PR author is added to the allowed list. Updated the wording to use this implicit form, and to emphasize that it should be done on one of the user's own PRs.
logiclrd
force-pushed
the
GettingAllowedHint
branch
from
e3fcca7 to
fe5567a
Compare
dscho
approved these changes
Oct 28, 2019
Member
|
Excellent! Thank you all! |
gitster
pushed a commit
to git/git
that referenced
this pull request
Nov 2, 2019
GitGitGadget, a handy tool for converting pull requests against Git into Git-mailing-list-friendly-patch-emails, requires as anti-spam that all new users be "/allow"ed by an existing user once before it will do anything for that new user. While this tutorial explained that mechanism, it did not give much hint on how to go about finding someone to allow your new pull request. So, teach our new GitGitGadget user where to look for someone who can add their name to the list. The advice in this patch is based on the advice proposed for GitGitGadget: gitgitgadget/gitgitgadget#138 Signed-off-by: Emily Shaffer <emilyshaffer@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some text to the "Contributing the patches" section in
WELCOME.mdthat provides a reference to the #git-devel IRC channel as a good place to find other contributors who can /allow you for GitGitGadget.