Conversation
As of a year or two ago, there is this push to align MSYS2 more closely with Cygwin, so as to benefit from a closer collaboration. Part of that is that the triplet `x86_64-pc-cygwin` is used nowadays, whereas it had been `x86_64-pc-msys` previously. Likewise, Perl now reports `$^O` as `cygwin` instead of `msys`. The Perl module test used `msys` as tell-tale when to accommodate for a native Windows version of `git.exe` which would report absolute _Windows_ paths rather than those pseudo-Unix paths. We cannot use that tell-tale anymore, and we also cannot adjust it to `cygwin` because that would break in Cygwin (where `git.exe` reports absolute pseudo-Unix paths). Let's use the environment variable `MSYSTEM` instead (being mindful that the `MSYSTEM=MSYS` variant would _also_ reflect a setup where `git.exe` won't report absolute _Windows_ paths). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The assumption of this test is that Perl and Git have the same idea how to perform encoding conversions. However, in Git for Windows, Git is a native Win32 program, and such programs have a very different concept of encodings (called "Code Pages", and they are not controlled via environment variables at all), whereas the Perl interpreter used in Git for Windows is a pseudo-Unix one that uses the MSYS2 runtime (which _does_ try very much to abide by Unix' `LC_ALL` and friends, and totally ignores Windows' current or active code pages). As such, these test cases _cannot_ work with Git for Windows. So let's just skip them on that platform. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
fix-perl-related-test-failures-on-windows
branch
from
September 13, 2026 18:00
ebb2ecf to
8d065f1
Compare
Member
Author
|
/submit |
|
Submitted as pull.2227.git.1789326667.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This branch is now known as |
|
This patch series was integrated into seen via git@021df6f. |
|
This patch series was integrated into next via git@c797ae1. |
|
There was a status update in the "New Topics" section about the branch Correct tests that depend on Perl running on MinGW Will merge to 'master'. source: <pull.2227.git.1789326667.gitgitgadget@gmail.com> |
|
This patch series was integrated into master via git@6fc1571. |
|
Congratulations! 🎉 Your patch series was merged into upstream via 6fc1571. Note: this pull request will show as "Closed" rather than "Merged" because the merge happened in the upstream repository, not on GitHub. This is expected — your contribution has been accepted! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For performance reasons (and also because we retired support for
git svnin Git for Windows), Perl-related tests are skipped from the CI builds. As can be expected, this caused some bit-rot.While this is not exactly -rc1 material, in preparing for Git for Windows v2.56.0-rc0 I did run the entire test suite on Windows/ARM64 and these were the only two bugs that needed fixing.