Skip to content

completion: complete 'git worktree repair' - #2218

Open
yoichi wants to merge 1 commit into
gitgitgadget:masterfrom
yoichi:complete-worktree-repair
Open

yoichi wants to merge 1 commit into
gitgitgadget:masterfrom
yoichi:complete-worktree-repair

Conversation

@yoichi

@yoichi yoichi commented Sep 5, 2026

Copy link
Copy Markdown

cc: Patrick Steinhardt ps@pks.im
cc: Yoichi Nakayama yoichi.nakayama@gmail.com

@gitgitgadget

gitgitgadget Bot commented Sep 5, 2026

Copy link
Copy Markdown

There is an issue in commit 60be4bb:
completion: complete 'git worktree repair'

  • Commit not signed off

@yoichi
yoichi force-pushed the complete-worktree-repair branch 3 times, most recently from 9ac3280 to 84cfa0d Compare September 11, 2026 22:54
@yoichi

yoichi commented Sep 12, 2026

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented Sep 12, 2026

Copy link
Copy Markdown

Submitted as pull.2218.git.1789171955370.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2218/yoichi/complete-worktree-repair-v1

To fetch this version to local tag pr-2218/yoichi/complete-worktree-repair-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2218/yoichi/complete-worktree-repair-v1

The completion scripts do not complete the "repair" subcommand for
git-worktree(1). Add support for it.

Signed-off-by: Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
@yoichi
yoichi force-pushed the complete-worktree-repair branch from 84cfa0d to 4f3f233 Compare September 14, 2026 12:09
@gitgitgadget

gitgitgadget Bot commented Sep 14, 2026

Copy link
Copy Markdown

Patrick Steinhardt wrote on the Git mailing list (how to reply to this email):

On Sat, Sep 12, 2026 at 12:12:35AM +0000, Yoichi NAKAYAMA via GitGitGadget wrote:
> From: Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
> 
> Added completion support for the 'repair' subcommand of worktree. It
> optionally receives a list of paths to linked worktrees or paths to
> worktrees with broken links.

We typically write commit messages in imperative mood, as if instructing
the code to change. We also briefly describe the status quo, even though
it's not as important in this particular case. An example could be:

  Our Bash completion does not know to complete the "repair" subcommand
  for git-worktree(1). Add support for it.

One could also try to add in your bit about worktree paths, but that's
something that's quite obviously visible from the diff anyway. So this
may or may not be valuable.

Other than that the patch looks good to me.

Thanks!

Patrick

@gitgitgadget

gitgitgadget Bot commented Sep 14, 2026

Copy link
Copy Markdown

User Patrick Steinhardt <ps@pks.im> has been added to the cc: list.

@gitgitgadget

gitgitgadget Bot commented Sep 14, 2026

Copy link
Copy Markdown

Yoichi Nakayama wrote on the Git mailing list (how to reply to this email):

On Mon, Sep 14, 2026 at 3:29 PM Patrick Steinhardt <ps@pks.im> wrote:
>
> On Sat, Sep 12, 2026 at 12:12:35AM +0000, Yoichi NAKAYAMA via GitGitGadget wrote:
> > From: Yoichi NAKAYAMA <yoichi.nakayama@gmail.com>
> >
> > Added completion support for the 'repair' subcommand of worktree. It
> > optionally receives a list of paths to linked worktrees or paths to
> > worktrees with broken links.
>
> We typically write commit messages in imperative mood, as if instructing
> the code to change. We also briefly describe the status quo, even though
> it's not as important in this particular case. An example could be:
>
>   Our Bash completion does not know to complete the "repair" subcommand
>   for git-worktree(1). Add support for it.
>
> One could also try to add in your bit about worktree paths, but that's
> something that's quite obviously visible from the diff anyway. So this
> may or may not be valuable.

Thank you for your comment.
Since this is not limited to bash, it also adds completion support
for zsh and tcsh via git-completion.{zsh,tcsh}.
So I'd like to modify the body of the commit message as follows:

  The completion scripts do not complete the "repair" subcommand for
  git-worktree(1). Add support for it.

Thanks

> Other than that the patch looks good to me.
>
> Thanks!
>
> Patrick



-- 
Yoichi NAKAYAMA

@gitgitgadget

gitgitgadget Bot commented Sep 14, 2026

Copy link
Copy Markdown

User Yoichi Nakayama <yoichi.nakayama@gmail.com> has been added to the cc: list.

@yoichi

yoichi commented Sep 14, 2026

Copy link
Copy Markdown
Author

/submit

@gitgitgadget

gitgitgadget Bot commented Sep 14, 2026

Copy link
Copy Markdown

Submitted as pull.2218.v2.git.1789414536838.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2218/yoichi/complete-worktree-repair-v2

To fetch this version to local tag pr-2218/yoichi/complete-worktree-repair-v2:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2218/yoichi/complete-worktree-repair-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant