fix(metrics): Replace invalid tag values with an empty string instead of _ (getsentry#2773)

markushi · web-flow · commit f87440749ccd · 2024-02-28T10:45:23.000+01:00
diff --git a/sentry_sdk/metrics.py b/sentry_sdk/metrics.py
@@ -55,7 +55,7 @@
 
 _in_metrics = ContextVar("in_metrics", default=False)
 _sanitize_key = partial(re.compile(r"[^a-zA-Z0-9_/.-]+").sub, "_")
-_sanitize_value = partial(re.compile(r"[^\w\d_:/@\.{}\[\]$-]+", re.UNICODE).sub, "_")
+_sanitize_value = partial(re.compile(r"[^\w\d_:/@\.{}\[\]$-]+", re.UNICODE).sub, "")
 _set = set  # set is shadowed below
 
 GOOD_TRANSACTION_SOURCES = frozenset(
diff --git a/tests/test_metrics.py b/tests/test_metrics.py
@@ -822,7 +822,7 @@ def test_tag_normalization(
 
     assert len(m) == 3
     assert m[0][4] == {
-        "foo-bar": "_$foo",
+        "foo-bar": "$foo",
         "release": "fun-release@1.0.0",
         "environment": "not-fun-env",
     }
