ref(pymongo): Remove redundant command name in query description (getsentry#3189)

0Calories · web-flow · commit ec7172e15311 · 2024-06-21T07:27:41.000+02:00
The query command is already included as the first key within the command JSON, so query spans end up having the command twice in the desription.
diff --git a/sentry_sdk/integrations/pymongo.py b/sentry_sdk/integrations/pymongo.py
@@ -155,7 +155,7 @@ def started(self, event):
             if not should_send_default_pii():
                 command = _strip_pii(command)
 
-            query = "{} {}".format(event.command_name, command)
+            query = "{}".format(command)
             span = sentry_sdk.start_span(op=op, description=query)
 
             for tag, value in tags.items():
diff --git a/tests/integrations/pymongo/test_pymongo.py b/tests/integrations/pymongo/test_pymongo.py
@@ -71,9 +71,9 @@ def test_transactions(sentry_init, capture_events, mongo_server, with_pii):
     assert insert_success["tags"]["db.operation"] == "insert"
     assert insert_fail["tags"]["db.operation"] == "insert"
 
-    assert find["description"].startswith("find {")
-    assert insert_success["description"].startswith("insert {")
-    assert insert_fail["description"].startswith("insert {")
+    assert find["description"].startswith("{'find")
+    assert insert_success["description"].startswith("{'insert")
+    assert insert_fail["description"].startswith("{'insert")
     if with_pii:
         assert "1" in find["description"]
         assert "2" in insert_success["description"]
@@ -113,7 +113,7 @@ def test_breadcrumbs(sentry_init, capture_events, mongo_server, with_pii):
     (crumb,) = event["breadcrumbs"]["values"]
 
     assert crumb["category"] == "query"
-    assert crumb["message"].startswith("find {")
+    assert crumb["message"].startswith("{'find")
     if with_pii:
         assert "1" in crumb["message"]
     else:
