Address inconsistency in changelogs#176
Merged
arzzen merged 1 commit intogit-quick-stats:masterfrom Oct 25, 2024
Merged
Conversation
* Original function lacked explicit sorting by time. Adding sorting by time within the same day to help make changelogs consistent.
Collaborator
Author
|
Tested with the provided repo. We now get the following without an author: ice@3900x:Shapes-Dataset(main)$ ./git-quick-stats -c
Git changelogs:
[2022-03-24]
* Update README.md (Daraan)
[2022-03-10]
* Update README.md (Daraan)
* Update README.md (Daraan)
* Added Classifier and images (Daraan)
* Added generator and updated help (Daraan)
[2022-03-09]
* Initial commit (Daraan)And the following with an author: ice@3900x:Shapes-Dataset(main)$ ./git-quick-stats -L
Which author? Daraan
Git changelogs for author 'Daraan':
[2022-03-24]
* Update README.md (Daraan)
[2022-03-10]
* Update README.md (Daraan)
* Update README.md (Daraan)
* Added Classifier and images (Daraan)
* Added generator and updated help (Daraan)
[2022-03-09]
* Initial commit (Daraan)
ice@3900x:Shapes-Dataset(main)$Also tested on our own repo: ice@3900x:git-quick-stats(bugfix/161-changelogs-wrong-output)$ git log -n 13 --no-merges --oneline
fb488ab (HEAD -> bugfix/161-changelogs-wrong-output, origin/bugfix/161-changelogs-wrong-output) Address inconsistency in changelogs
d4e56cf Adjust commitsByYear() to support multiple dates
cf239e5 (tag: 2.5.7) Update README.md
7d50877 Address more feedback
fe2df31 Address review feedback
6155634 Fix stats for situation where there are no inserts / deletes
8c1d81a Add a list of new contributors
5b01b5e Update documentation for clarity
cd6d67d improve macos error message wrt gnu date
b525ed3 Create new repo if running tests in non-git area
41a8542 Handle error where BSD date is being used
43bc825 calculate the day before the given since date as it excludes the given daten the inclusion is wanted
62b128a docs: Document default `_GIT_LIMIT` value
ice@3900x:git-quick-stats(bugfix/161-changelogs-wrong-output)$ ./git-quick-stats -c
Git changelogs:
[2024-10-12]
* Address inconsistency in changelogs (Tom Ice)
[2024-10-01]
* Adjust commitsByYear() to support multiple dates (Tom Ice)
[2024-09-19]
* Update README.md (Tom Ice)
* Address more feedback (Ben Cotton)
* Address review feedback (Ben Cotton)
[2024-09-17]
* Fix stats for situation where there are no inserts / deletes (Michael Robinson)
[2024-06-26]
* Add a list of new contributors (Ben Cotton)
[2024-05-16]
* Update documentation for clarity (Tom Ice)
[2024-04-28]
* improve macos error message wrt gnu date (Rui Chen)
[2024-04-20]
* Create new repo if running tests in non-git area (Tom Ice)
* Handle error where BSD date is being used (Tom Ice)
[2024-01-09]
* calculate the day before the given since date as it excludes the given daten the inclusion is wanted (Martin Schaaf)
[2023-11-18]
* docs: Document default `_GIT_LIMIT` value (Edwin Kofler)
ice@3900x:git-quick-stats(bugfix/161-changelogs-wrong-output)$ |
funnelfiasco
approved these changes
Oct 14, 2024
Contributor
funnelfiasco
left a comment
funnelfiasco
left a comment
There was a problem hiding this comment.
I don't have write access to this repo, so this review doesn't actually count, but it looks good to me.
arzzen
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161