Add a list of new contributors#170
Merged
tomice merged 3 commits intogit-quick-stats:masterfrom Sep 19, 2024
Merged
Conversation
This reports generates a list of all contributors whose first commit was after a specified date. Fixes git-quick-stats#169 Signed-off-by: Ben Cotton <bcotton@funnelfiasco.com>
funnelfiasco
force-pushed
the
issue169-add_new_contributors
branch
from
65aef82 to
8c1d81a
Compare
tomice
reviewed
Sep 18, 2024
Collaborator
|
Thanks for your contribution! Really sorry, I only just saw this. Peer reviewed this for you and added a couple suggestions. |
Contributor
Author
|
I appreciate the review, @tomice! I'll have some time tomorrow to make and test the suggested changes. |
* Indicate how we're sorting new contributors * Don't fork for `date` checks * Include reference in the manpage Signed-off-by: Ben Cotton <bcotton@funnelfiasco.com>
Contributor
Author
|
Pushed with fixes for feedback. I'ld be happy to squash after review if that's preferred. |
tomice
reviewed
Sep 19, 2024
* Add date examples to prompts * Update tests Signed-off-by: Ben Cotton <bcotton@funnelfiasco.com>
Contributor
Author
|
Updated! |
tomice
approved these changes
Sep 19, 2024
Collaborator
tomice
left a comment
tomice
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reports generates a list of all contributors whose first commit was after a specified date.
I've tested this with several date formats, including invalid ones, and added a check of the date prior to trying to use it.
Fixes #169