Skip to content

fix: build the remote lock message on macOS - #679

Open
stantheman0128 wants to merge 1 commit into
git-ftp:masterfrom
stantheman0128:fix/mac-lock-stamp
Open

stantheman0128 wants to merge 1 commit into
git-ftp:masterfrom
stantheman0128:fix/mac-lock-stamp

Conversation

@stantheman0128

Copy link
Copy Markdown

Summary

Fixes #520.

remote_lock built its message with hostname --fqdn and date --utc --rfc-2822. macOS rejects both long options (illegal option -- -). The stamp now uses those forms when they work, and hostname -f plus date -u with an RFC 2822 format otherwise.

prepared with Cursor

Verification

Red, this Mac:

hostname --fqdn
exit 1
hostname: illegal option -- -

date --utc --rfc-2822
exit 1
date: illegal option -- -

Green:

bash tests/lock-stamp-darwin.test.sh
git-ftp lock stamp darwin ok (hostname 1, date 1, fqdn zhengqiaoyundeMacBook-Pro.local, stamp Tue, 22 Sep 2026 18:48:17 +0000)

The full git ftp download --lock path was not run. It needs a remote. The two commands that failed in the issue log are the ones this test runs.

Made with Cursor

hostname --fqdn and date --utc --rfc-2822 are GNU options. Both are
rejected here, so git ftp --lock died before uploading the lock.

Co-authored-by: Cursor <cursoragent@cursor.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lock on macOS

1 participant