Repository navigation
Ability to set deployedsha1file instead of hardcoded. Both command li… - #605
Open
KentonMurray wants to merge 1 commit into
Open
KentonMurray wants to merge 1 commit into
KentonMurray wants to merge 1 commit into
Conversation
…ne and through config
mkllnk
requested changes
Mar 8, 2021
mkllnk
left a comment
mkllnk
left a comment
Member
There was a problem hiding this comment.
Thank you!
I left a couple of comments.
Comment on lines
-386
to
+392
| DEPLOYED_SHA1_FILE="$(get_config deployedsha1file "$DEPLOYED_SHA1_FILE")" | ||
| DEPLOYED_SHA1_FILE_CONFIG="$(get_config deployedsha1file)" | ||
| if [ -z "$DEPLOYED_SHA1_FILE_CONFIG" ]; then | ||
| DEPLOYED_SHA1_FILE="$(get_config deployedsha1file "$DEPLOYED_SHA1_FILE")" #If none in config, rerun with harcoded value | ||
| else | ||
| DEPLOYED_SHA1_FILE=$DEPLOYED_SHA1_FILE_CONFIG | ||
| fi |
Member
There was a problem hiding this comment.
I don't understand this change. The old line should have done exactly the same. If the config variable is set then $(get_config deployedsha1file "$DEPLOYED_SHA1_FILE") will return the config option. If it's not set then it will return the original value of $DEPLOYED_SHA1_FILE.
| --enable-post-errors Fails if post-ftp-push hook raises an error | ||
| --disable-epsv Tell curl to disable the use of the EPSV command when doing passive FTP transfers. Curl will normally always first attempt to use EPSV before PASV, but with this option, it will not try using EPSV. | ||
| --auto-init Automatically run init action when running push action | ||
| --deployedsha1file The name of the file that keeps the SHA1 hash of the current git commit |
Member
There was a problem hiding this comment.
The formatting is a bit off here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ne and through config
This is a PR in response to issue: #604
It passes local tests (I did not write any additional). I don't think there's a need to update any man pages nor docs.