Skip to content

Update INSTALL.md #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lennard0711 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update INSTALL.md #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,13 @@ There are at least two ways to install git-ftp on Windows.
### Git for Windows, former msysgit (recommended)

Install [Git for Windows](https://git-for-windows.github.io/).
It comes with curl installed, but it doesn't support SFTP by default.
~~It comes with curl installed, but it doesn't support SFTP by default.
In order to use SFTP, [download curl](http://curl.haxx.se/download.html) for
Windows with SFTP support.
Win32 2000/XP MSI or Win64 2000/XP x86_64 MSI is recommended.
If you installed curl, then remove `bin/curl.exe` from your Git for Windows
installation directory. It will fall back to the newly installed version.
installation directory. It will fall back to the newly installed version.~~

@LukasFritzeDev LukasFritzeDev Jun 18, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest not crossing that off. There may still be users of older versions of Windows who need this information. So why not say something like:

+ Older versions of Windows come with curl installed, but …

Windows 10 comes now preinstalled with the correct cURL version.

@LukasFritzeDev LukasFritzeDev Jun 18, 2019

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify which version of Windows 10 introduces the updated cURL version?
Again maybe a user has a older version. Then this information could be useful.
Maybe like:

+ Since Windows 10 version XXXX a cURL installation supporting SFTP is preinstalled.

And then the suggestion from above.

@fxmauricard fxmauricard Jul 31, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do curl -V in Windows 10 2004 we have this:

curl 7.55.1 (Windows) libcurl/7.55.1 WinSSL
Release-Date: 2017-11-14, security patched: 2019-11-05
Protocols: dict file ftp ftps http https imap imaps pop3 pop3s smtp smtps telnet tftp
Features: AsynchDNS IPv6 Largefile SSPI Kerberos SPNEGO NTLM SSL

If we do curl -V in the latest Git Bash we have this:

curl 7.71.1 (x86_64-w64-mingw32) libcurl/7.71.1 OpenSSL/1.1.1g (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.3.0 libssh2/1.9.0 nghttp2/1.41.0
Release-Date: 2020-07-01
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp
Features: AsynchDNS brotli HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz Metalink MultiSSL NTLM SPNEGO SSL SSPI TLS-SRP

So, AFAIK, there's no support for SFTP unless we use the cURL provided on the cURL website or the latest Git for Windows.
In fact it was only broken between version 2.16.2 and 2.25 versions. From version 2.25.1, SFTP support in the included cURL was restored.


Finally, open the Git Bash which is located in `C:\Program Files (x86)\Git`
by default.
Expand Down