Repository navigation
Add Feature: Set Logfile name via config #604
Description
I use git-ftp to host my website. My hosting provider does not allow .log files to be uploaded through their FTP server. This generates a 553 error. To get around this, I had to build this from source, but modifying
Line 53 in 057f7d8
DEPLOYED_SHA1_FILE=".git-ftp.log" to a file format that was allowed. It would be nice if this was able to be set through the config file.
I can submit a pull request if desired, but I am not too familiar with the code. What I think it would look like:
I think the following function needs to be changed
set_deployed_sha1_file() {
DEPLOYED_SHA1_FILE="$(get_config deployedsha1file "$DEPLOYED_SHA1_FILE")"
}
Line 386 in 057f7d8
My understanding is that $DEPLOYED_SHA1_FILE is hardcoded in at:
Line 53 in 057f7d8
If I'm understanding the code correctly, in the set_deployed_sha1_file function, when get_config() is called, it is passing this hardcoded value. It would be nice to have the option to pass
Line 223 in 057f7d8
".git-ftp.log" but allow for users to customize.
Activity
mkllnk commentedon Mar 7, 2021
That's a great suggestion. Can you open a pull request?
KentonMurray commentedon Mar 7, 2021
New functionality:
git ftp init -vvSun Mar 7 13:49:35 EST 2021: The remote sha1 is saved in file '.git-ftp.log'.git ftp init -vv --deployedsha1file TESTSun Mar 7 13:49:35 EST 2021: The remote sha1 is saved in file 'TEST.log'.git config git-ftp.deployedsha1file "TEST2.log"git ftp init -vvSun Mar 7 13:49:35 EST 2021: The remote sha1 is saved in file 'TEST2.log'.