Skip to content

use gpg profile on release, not sonatype-oss-release#711

Merged
TheSnoozer merged 1 commit into
git-commit-id:masterfrom
hboutemy:patch-1
Mar 5, 2024
Merged

use gpg profile on release, not sonatype-oss-release#711
TheSnoozer merged 1 commit into
git-commit-id:masterfrom
hboutemy:patch-1

Conversation

@hboutemy

@hboutemy hboutemy commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Context

investigating Reproducible Builds issue https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/io/github/git-commit-id/README.md

Contributor Checklist

see mvn help:effective-pom -Dverbose -Psonatype-oss-release
vs mvn help:effective-pom -Dverbose -Pgpg
particularly at maven-source-plugin level

@TheSnoozer

Copy link
Copy Markdown
Collaborator

Thanks for your contribution!
Indeed during the last release I noticed that one of the artifacts was not correctly signed.

Screenshot from 2024-03-04 21-09-19
Screenshot from 2024-03-04 21-09-47

So I hope that your contribution saved me from investigating :-)

Thanks again! LGTM

@TheSnoozer TheSnoozer merged commit 33c20c0 into git-commit-id:master Mar 5, 2024
@TheSnoozer TheSnoozer added this to the 9.0.0 milestone Mar 5, 2024
TheSnoozer pushed a commit to git-commit-id/git-commit-id-plugin-core that referenced this pull request Mar 5, 2024
@hboutemy hboutemy deleted the patch-1 branch March 10, 2024 14:53
@hboutemy

Copy link
Copy Markdown
Contributor Author

release 8.0.1 is fully reproducible!!!

@TheSnoozer

Copy link
Copy Markdown
Collaborator

Great thanks again for your contribution to make the build reproducible!

@TheSnoozer TheSnoozer modified the milestones: 9.0.0, 8.0.1 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants