Improve gitdir handling with submodules#135
Improve gitdir handling with submodules#135ktoso merged 2 commits intogit-commit-id:masterfrom maiergre:master
Conversation
When using git submodules, some versions of git (e.g., 1.7.9) use abosulate path in the gitdir reference of the submodules. This patch adds support to handle absoluate path correctly.
When searching for the git directory of a project the search follows the project's basedir parent directory rather than following the project hierarchy (which is not correct)
|
@ktoso I was wondering whether you had a chance to look at this pull request |
|
Sorry, not yet, was very busy with Akka this week. But should be able to Thanks for your patience! Konrad
|
There was a problem hiding this comment.
gitdir is always != null here
|
Seems good to me, and tests pass. Unless I missed some edge case this should be fine - thanks for the contribution! |
Improve gitdir handling with submodules
|
Hi thanks for the great project, so that we can track the commit message in the distribute env easily. I have a question about searching for .git in the parent directory: do we need to add an option to not search the parent directory when finding the Now we will search all parent directories from the current directory to find the The background of this case is that I am contributing to an open-source project. this project wants to report an error without |
3 participants
Thanks for the plugin!
This pull req fixes two issues I encountered: