Skip to content

fix: resolve Go vulnerabilities #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelMure merged 4 commits into from
Jan 8, 2023
Merged

fix: resolve Go vulnerabilities #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33e3e4b
fix: resolve Go vulnerabilities
smoyer64 Jan 3, 2023
58a6962
ci: use Go 1.19.4 and setup-go@v3
smoyer64 Jan 4, 2023
4cee3a7
test(cache): close second instance of RepoCache
smoyer64 Jan 4, 2023
59684d7
style(TestCache): remove empty trailing line from function
smoyer64 Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.18.x
go-version: 1.19.4
- uses: actions/checkout@v3
# Run benchmark with `go test -bench` and stores the output to a file
- name: Run benchmark
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ jobs:

strategy:
matrix:
go-version: [1.18.x]
go-version: [1.19.4]
platform: [ubuntu-latest, macos-latest, windows-latest]

runs-on: ${{ matrix.platform }}

steps:

- name: Set up Go ${{ matrix.node-version }}
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: ${{ matrix.go-version }}

Expand All @@ -44,13 +44,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: 1.18.x
go-version: 1.19.4

- name: Checkout code
uses: actions/checkout@v2

- name: Check Code Formatting
run: find . -name "*.go" | while read line; do [ -z "$(gofmt -d "$line" | head)" ] || exit 1; done

6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:

steps:
- name: Set up Go
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: 1.18.x
go-version: 1.19.4

- name: Check out code
uses: actions/checkout@v2
Expand All @@ -38,4 +38,4 @@ jobs:
repo_token: "${{ secrets.GITHUB_TOKEN }}"
draft: true
prerelease: false
files: dist/*
files: dist/*
7 changes: 7 additions & 0 deletions cache/repo_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ func TestCache(t *testing.T) {
require.NoError(t, err)
_, err = cache.Bugs().ResolvePrefix(bug1.Id().String()[:10])
require.NoError(t, err)

// Close
require.NoError(t, cache.Close())
require.Empty(t, cache.bugs.cached)
require.Empty(t, cache.bugs.excerpts)
require.Empty(t, cache.identities.cached)
require.Empty(t, cache.identities.excerpts)
}

func TestCachePushPull(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/MichaelMure/git-bug

go 1.18
go 1.19

require (
github.com/99designs/gqlgen v0.17.20
Expand Down