Skip to content

fix: resolve Go vulnerabilities#976

Merged
MichaelMure merged 4 commits intomasterfrom
fix/975/patch-security-vulnerabilities
Jan 8, 2023
Merged

fix: resolve Go vulnerabilities#976
MichaelMure merged 4 commits intomasterfrom
fix/975/patch-security-vulnerabilities

Conversation

@smoyer64
Copy link
Collaborator

@smoyer64 smoyer64 commented Jan 3, 2023

Resolves #975

@smoyer64 smoyer64 requested a review from MichaelMure January 3, 2023 15:21
Copy link
Contributor

@MichaelMure MichaelMure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the IDE problems, I'm a bit wary to update too quickly the requirements as it can make it difficult to package for distro. But alright, let see how it goes.
Note that you don't actually require golang 1.19.4 (1 month old), but just golang 1.19 (6 months old).

@smoyer64 smoyer64 force-pushed the fix/975/patch-security-vulnerabilities branch from 742a96c to 33e3e4b Compare January 3, 2023 23:28
@smoyer64
Copy link
Collaborator Author

smoyer64 commented Jan 3, 2023

That's really weird ... I only changed and committed the module file and three of the workflows but it failed linting and looking at my history, I ran go fmt ./... - perhaps it's rules are different in Go 1.19. I reverted to 33e3e4b and only see the four expected changed files. Now I just need to see why the linter is complaining!

@MichaelMure MichaelMure merged commit c7662a1 into master Jan 8, 2023
@MichaelMure MichaelMure deleted the fix/975/patch-security-vulnerabilities branch January 8, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Critical security vulnerabilities in Go's standard library

2 participants