Support new GitHub token formats#636
Merged
MichaelMure merged 1 commit intogit-bug:masterfrom Apr 19, 2021
ellsclytn:fix/new-gh-token-format
Merged
Support new GitHub token formats#636MichaelMure merged 1 commit intogit-bug:masterfrom ellsclytn:fix/new-gh-token-format
MichaelMure merged 1 commit intogit-bug:masterfrom
ellsclytn:fix/new-gh-token-format
Conversation
GitHub have introduced a new format for their access tokens, which does not fit within the rules of the previous regex. For the time being, the previous token format is still being supported by GitHub, so it makes sense to continue allowing legacy tokens. https://github.blog/changelog/2021-03-04-authentication-token-format-updates/
Contributor
Author
|
I went for the approach of two separate regexes because I think it's a little more readable, and a little easier to maintain (dropping support for legacy tokens is as simple as deleting the old regex, and its use in the |
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub have introduced a new format for their access tokens, which does
not fit within the rules of the previous regex. For the time being, the
previous token format is still being supported by GitHub, so it makes
sense to continue allowing legacy tokens.
https://github.blog/changelog/2021-03-04-authentication-token-format-updates/