feat(config): add git-bug.remote for defining the default remote #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudoforge
requested changes
May 19, 2025
Contributor
There was a problem hiding this comment.
thanks for submitting @wahern's contribution!
as a general rule, for changes like this, we'd like to see unit tests added in concert. there's an existing test for this interface in //repository:config_test.go; that file would be a great place to implement tests for the new GetDefaultString().
you can also update your commit message to add a Closes: #11 trailer -- i think this effectively implements that.
sudoforge
changed the title
mcepl
force-pushed
the
non-default-remote
branch
from
961f239 to
6421053
Compare
mcepl
force-pushed
the
non-default-remote
branch
from
6421053 to
b586ce8
Compare
mcepl
force-pushed
the
non-default-remote
branch
2 times, most recently
from
6f325ff to
9973497
Compare
Contributor
Author
|
@sudoforge I have added some tests. What’s remaining here? The patch works pretty well for me. |
Other way is to have explicit REMOTE argument. Fixes: git-bug#11 Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
mcepl
force-pushed
the
non-default-remote
branch
from
9973497 to
2a63464
Compare
sudoforge
requested changes
Jan 21, 2026
Contributor
sudoforge
left a comment
sudoforge
left a comment
There was a problem hiding this comment.
overall, this looks good - there's just one minor issue with the schema file that i imagine crept in during some rebasing. thanks for the contribution!
Adds a new test function, `TestGetDefaultString`, to verify the logic for reading string configuration values with a default fallback. This test covers multiple scenarios: - A missing key correctly returns the default value. - An existing key returns its stored value. - A key with an empty string value returns the empty string, not the default. The test also explicitly validates the behavior for the `git-bug.remote` configuration to ensure the new remote-setting feature is correctly handled by the underlying config reader. Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
mcepl
force-pushed
the
non-default-remote
branch
from
2a63464 to
257a492
Compare
sudoforge
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other way is to have explicit REMOTE argument.