build(web): npm tooling upgrades (pre MUI)#1430
build(web): npm tooling upgrades (pre MUI)#1430lygaret wants to merge 5 commits intogit-bug:masterfrom
Conversation
eslint plugin was left alone because eslint is a whole thing
i'm in the process of dropping prettier here: #1429
i'll be removing this too. #1429 exposes so basically, with that first box checked, you're done with these goals :) |
|
|
|
oh, nvm then. i saw "formatter" and didn't put that together as the markdown rendering lib that's used. |
yeah, sorry for the confusion, changed the wording to renderer so it shows up right in the squash |
updates remark/rehype/unified to the latest versions, and reconfigures the markdown pipeline to be more efficient and use the latest plugins. the pipeline now includes GFM style features like code highlighting, footnotes, inline urls, and hard line breaks, and no longer double parses to html. also implements the first part of code highlighting in markdown, what's left is correctly bringing in theme css files
p>div is not a valid nesting in HTML, and with strict-mode turned on, react complains about it. this fix allows labels to be inline, and then uses that in the LabelChange component to avoid getting hydration warnings from react
the full theme is loaded, but controled by a parent's data attribute.
|
with the latest remark/rehype/unified versions, I also brought in a syntax highlighting plugin, mostly because it was easy, since I had already dealt with hacking the pipeline to pieces. I think this would close #580. The theme is @sudoforge if you'd like, I can also submit PRs for each of these changes separately, I just got a bit carried away on this one. Please test this out and let me know if there's any markdown that doesn't seem to be rendering correctly; I looked quite a bit, but it all looks normal to me.
|
|
Giving up on eslint for now, since I think that will have to change once nix is doing formatting. |
|
Really nice! |
this isn't a documented contribution requirement or anything, but yes, i would prefer that logically independent changes were submitted individually, however, i can enable rebase merging on the repository and take these commits in individually for now. that does, however, require that the merge queue is bypassed -- which is fine, it's mostly just there for an easier autonomous submit/review/refactor/merge loop -- because it will squash all of the commits from a PR into one. |
|
ok, @sudoforge I will break this into the graphql tools, then remark + highlighting (because those will be much harder to split). I'll title the remark upgrade as intended to close the highlighting issue, where the upgrade is an implementation detail. |
|
no, no, my comment was telling you that there's no need to, i can merge it so that they're individual on HEAD. i'll wait to test it out until i get the signal from you that it's ready to review again -- one quick q: can we adjust the indent level to 4? that feels like a sane default for now, and in the future we could expose this as a setting for the user. |
afaiu, the indent you're seeing in the screenshot is purely from the input; all the highlighting does is wrap tokens with syntax classes and add colors. That particular issue was a bad example, because I'm pretty sure that's 8 spaces lol
I think I'll be more comfortable if I break it up anyway, so no worries; they're pretty close to ready for cherry-picking. |
|
I'll have these for you later this evening, time for me to go do family stuff! 👋 |
i assumed it was a tab character, and that remark was indenting it at 8, since a tab is the correct indentation character for a git config file, but now i'm seeing that even in my comments on that issue, which were copy-pasta'd from my config (in which i use tabs), it looks like github has converted it to 8 spaces (or maybe my browser did, when i pasted it, or something). 🤷 no need to adjust this! |
3 participants
Uh oh!
There was an error while loading. Please reload this page.