fix: set GitLastTag to an empty string when git-describe errors#1355
Merged
fix: set GitLastTag to an empty string when git-describe errors#1355
Conversation
This change refactors the call to `git-describe` made in `//:Makefile`, such that if the call made to populate the `GitLastTag` build argument fails for any reason, the value is an empty string. This resolves a fairly common situation in CI, and reproducible elsewhere, if the local repository does not have any tags. Change-Id: Ie8e06360d5a4016596b96c6371ce4e32ad6a8afb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change refactors the call to
git-describemade in//:Makefile,such that if the call made to populate the
GitLastTagbuild argumentfails for any reason, the value is an empty string.
This resolves a fairly common situation in CI, and reproducible
elsewhere, if the local repository does not have any tags.
Change-Id: Ie8e06360d5a4016596b96c6371ce4e32ad6a8afb