Skip to content

fix: run the presubmit pipeline for PRs#1208

Merged
sudoforge merged 1 commit intomasterfrom
I56abc35c98cc40a06066952f2b6ed9194b1ab903
Jul 24, 2024
Merged

fix: run the presubmit pipeline for PRs#1208
sudoforge merged 1 commit intomasterfrom
I56abc35c98cc40a06066952f2b6ed9194b1ab903

Conversation

@sudoforge
Copy link
Contributor

@sudoforge sudoforge commented Jul 24, 2024

fix: run the presubmit pipeline for PRs

commit 5eabe549e4f7fc98bbdf4e7b285cec00e5da4e99 refactored the workflows
so that they were orchestrated with reusable workflows. an unintended
side-effect of the rules that were created prevents the presubmit
pipeline from executing for pull requests made against this repository.

this change refactors this, so that the presubmit pipeline will _only_
run for pull requests against the default tree of this repository. we
explicitly remove the `on: push` event for it, in order to avoid overlap
that will occur for commits made in this repository that are also part
of a PR.

Change-Id: I56abc35c98cc40a06066952f2b6ed9194b1ab903

@sudoforge sudoforge marked this pull request as ready for review July 24, 2024 03:38
@sudoforge sudoforge changed the title fix: run the presubmit pipeline only for PRs fix: run the presubmit pipeline for PRs Jul 24, 2024
commit 5eabe54 refactored the workflows
so that they were orchestrated with reusable workflows. an unintended
side-effect of the rules that were created prevents the presubmit
pipeline from executing for pull requests made against this repository.

this change refactors this, so that the presubmit pipeline will _only_
run for pull requests against the default tree of this repository. we
explicitly remove the `on: push` event for it, in order to avoid overlap
that will occur for commits made in this repository that are also part
of a PR.

Change-Id: I56abc35c98cc40a06066952f2b6ed9194b1ab903
@sudoforge sudoforge marked this pull request as draft July 24, 2024 04:15
@sudoforge sudoforge force-pushed the I56abc35c98cc40a06066952f2b6ed9194b1ab903 branch from 111fbb7 to f7b4295 Compare July 24, 2024 04:15
@sudoforge sudoforge marked this pull request as ready for review July 24, 2024 04:29
@sudoforge sudoforge merged commit 5893f94 into master Jul 24, 2024
@sudoforge sudoforge deleted the I56abc35c98cc40a06066952f2b6ed9194b1ab903 branch July 24, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant