Refactor sub-process support out of convert.c into a separate module#340
Closed
benpeart wants to merge 3 commits intogit:masterfrom
benpeart:refactor-convert
Closed
Refactor sub-process support out of convert.c into a separate module#340benpeart wants to merge 3 commits intogit:masterfrom benpeart:refactor-convert
benpeart wants to merge 3 commits intogit:masterfrom
benpeart:refactor-convert
Conversation
…cket_write_list_gently.
process and refactor it into a separate reusable “sub-process” module.
sub-process support.
Member
|
You could also give submitGit a try for submitting to the mailing list, if you haven't done it before: https://submitgit.herokuapp.com/git/git/pull/340 |
vdye
pushed a commit
to vdye/git
that referenced
this pull request
Jan 9, 2024
scalar: more `dir` cleanups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a couple of patch series we’re working on (ObjectDB/Read-Object, Watchman integration) where we could use the ability to have a background process running that can accept multiple commands thus avoiding the overhead of spawning a new process for every command. I’ve taken the code from LFS that does this and refactored it into a separate “sub-process” module so that we can centralize and reuse this logic. I also updated convert.c to use this new module.
I'll be posting this to the mailing list but understood that if I open a PR then a build for various platforms would be kicked off and tests run. I've verified this builds and passes all tests on Windows but no other platforms.