Repository navigation
ci: fix jobs failing on Ubuntu 26.04 - #2478
HaraldNordgren wants to merge 3 commits into
Conversation
The linux32 job prints
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
twice, once for "apt update" and once for "apt install". apt is meant
for interactive use. Call apt-get instead, like ci/install-dependencies.sh
already does.
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
When replacing `dirname`, elevation is required, otherwise the command will fail with: + ln -sfT /usr/bin/gnudirname /usr/bin/dirname ln: failed to create symbolic link '/usr/bin/dirname': Already exists as observed in https://github.com/git-for-windows/git/actions/runs/40223871341/job/121274294974?pr=6473#step:3:909 Based-on-patch-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
The linux32 job fails DNS resolution before checkout because Docker 29.4.2's seccomp profile on Ubuntu 26.04 blocks socketcall in i386 glibc containers. Ubuntu 24.04 avoids this host-side regression. actions/runner-images#14790 Based-on-patch-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
5cd2b98 to
37e837e
Compare
|
/submit |
|
Submitted as pull.2478.git.git.1793530936.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This patch series was integrated into seen via d81b80f. |
|
Junio C Hamano wrote on the Git mailing list (how to reply to this email): "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Four CI jobs fail since ubuntu-latest moved to Ubuntu 26.04.
>
> * documentation, fuzz smoke test and static-analysis fail with ln: failed
> to create symbolic link '/usr/bin/dirname': Already exists. Run the ln
> with sudo.
I see this breakage. Haven't they corrected the Rust rewrite of
dirname by now, by the way, to make this overwrite unnecessary yet?
> * linux32 cannot resolve deb.debian.org. Pin it to ubuntu-24.04. The Docker
> update in actions/runner-images#15205 fixes this on 26.04, but a new
> runner image will take a long time to roll out, and CI should not stay
> broken while we wait.
Sigh, but this one is rather straightforward. We need to be aware
of this change so that we can revert it when it becomes unnecessary.
> * Use apt-get in linux32 to get rid of the apt does not have a stable CLI
> interface warnings.
I can see this well, but it is a warning only, so I do not know how
much value in addressing it would be.
> The first two are based on Johannes Schindelin's fixes in Git for Windows
> (git-for-windows/git#6473).
>
> Harald Nordgren (3):
> ci: use apt-get in the linux32 job
> install-dependencies: work around a permission problem
> ci: pin linux32 to ubuntu-24.04 to restore networking
Will queue. Thanks.
>
> .github/workflows/main.yml | 6 ++++--
> ci/install-dependencies.sh | 2 +-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>
> base-commit: 50fe5cc63f9cd6e89b87a2c9ccf96a444f4cfdb7
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2478%2FHaraldNordgren%2Fci-linux32-apt-get-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2478/HaraldNordgren/ci-linux32-apt-get-v1
> Pull-Request: https://github.com/git/git/pull/2478 |
|
This branch is now known as |
|
There was a status update in the "New Topics" section about the branch The GitHub Actions CI jobs have been updated to fix breakages caused by the move to Ubuntu 26.04 runner images, including using 'apt-get' instead of 'apt' for stable CLI output, elevating permissions when replacing system binaries, and temporarily pinning the 'linux32' job to Ubuntu 24.04 to avoid seccomp-related networking failures. Will merge to 'next'? cf. <xmqqse1h4lmw.fsf@gitster.g> source: <pull.2478.git.git.1793530936.gitgitgadget@gmail.com> |
| if test -x /usr/bin/gnudirname | ||
| then | ||
| ln -sfT /usr/bin/gnudirname /usr/bin/dirname | ||
| sudo ln -sfT /usr/bin/gnudirname /usr/bin/dirname |
There was a problem hiding this comment.
| sudo ln -sfT /usr/bin/gnudirname /usr/bin/dirname | |
| sudo rm -rf /usr/bin/dirname | |
| sudo ln -sfT /usr/bin/gnudirname /usr/bin/dirname |
the problem was an already exist for "/usr/bin/dirname" deleting him is more safe .
|
This patch series was integrated into next via 4835211. |
|
There was a status update in the "Cooking" section about the branch The GitHub Actions CI jobs have been updated to fix breakages caused by the move to Ubuntu 26.04 runner images, including using 'apt-get' instead of 'apt' for stable CLI output, elevating permissions when replacing system binaries, and temporarily pinning the 'linux32' job to Ubuntu 24.04 to avoid seccomp-related networking failures. Will merge to 'master'. cf. <xmqqse1h4lmw.fsf@gitster.g> source: <pull.2478.git.git.1793530936.gitgitgadget@gmail.com> |
|
There was a status update in the "Cooking" section about the branch The GitHub Actions CI jobs have been updated to fix breakages caused by the move to Ubuntu 26.04 runner images, including using 'apt-get' instead of 'apt' for stable CLI output, elevating permissions when replacing system binaries, and temporarily pinning the 'linux32' job to Ubuntu 24.04 to avoid seccomp-related networking failures. Will merge to 'master'. cf. <xmqqse1h4lmw.fsf@gitster.g> source: <pull.2478.git.git.1793530936.gitgitgadget@gmail.com> |
Four CI jobs fail since
ubuntu-latestmoved to Ubuntu 26.04.ln: failed to create symbolic link '/usr/bin/dirname': Already exists. Run thelnwithsudo.deb.debian.org. Pin it to ubuntu-24.04. The Docker update in [Ubuntu 26.04] Update Docker to 29.7.2 actions/runner-images#15205 fixes this on 26.04, but a new runner image will take a long time to roll out, and CI should not stay broken while we wait.apt-getin linux32 to get rid of theapt does not have a stable CLI interfacewarnings.The first two are based on Johannes Schindelin's fixes in Git for Windows (git-for-windows#6473).