bisect: add --auto-reset to leave when done#2335
Open
HaraldNordgren wants to merge 2 commits into
Open
Conversation
github-project-automation
Bot
moved this to Todo
in Op-Amp Frequency Response and Applications Suite
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
11 times, most recently
from
June 14, 2026 10:44
a507afb to
1891e7d
Compare
HaraldNordgren
marked this pull request as draft
June 16, 2026 17:23
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
from
July 12, 2026 18:43
1891e7d to
a9194b1
Compare
HaraldNordgren
marked this pull request as ready for review
July 16, 2026 05:32
Contributor
Author
|
/submit |
|
Submitted as pull.2335.git.git.1784180159.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
from
July 16, 2026 05:39
a9194b1 to
e5a3091
Compare
![gitgitgadget-git[bot]](https://avatars.githubusercontent.com/in/46807?s=60&v=4){kind=small}
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
10 times, most recently
from
July 17, 2026 17:14
20b92e5 to
34d9c97
Compare
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
from
July 17, 2026 18:26
34d9c97 to
5b3704f
Compare
Contributor
Author
|
/submit |
|
Submitted as pull.2335.v2.git.git.1784312854.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
User |
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
from
July 18, 2026 23:52
5b3704f to
841014b
Compare
Add a "quiet" parameter to bisect_reset() that passes "--quiet" to the checkout restoring the original HEAD, suppressing its progress and branch-status output. No caller sets the flag yet, so behavior is unchanged. Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
When a bisection finishes, "git bisect" reports the first bad commit but leaves the session active until "git bisect reset" is run by hand. Add a "--reset-when-found[=<where>]" option, accepted by both "git bisect start" and "git bisect run", that resets as soon as the first bad commit is found. The "original" value returns to the commit checked out before "git bisect start", while "found" leaves the first bad commit checked out; omitting the value defaults to "original". Persist the selected target in a BISECT_RESET_WHEN_FOUND state file and perform the reset quietly. For "git bisect run", defer the reset until after the captured output is printed and BISECT_RUN is closed. This lets cleanup remove the file on systems that cannot unlink an open file. Reject this option together with "--no-checkout", since that mode must not check out either target. Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
HaraldNordgren
force-pushed
the
bisect-auto-reset
branch
from
July 19, 2026 00:11
841014b to
542f4b2
Compare
|
This branch is now known as |
|
This patch series was integrated into seen via ce18179. |
|
There was a status update in the "New Topics" section about the branch The 'git bisect' command has been taught a '--auto-reset[=<where>]' option that tells the command to automatically run 'git bisect reset' to jump back to the original state or to the found culprit. Waiting for response. cf. <1139ae20-f08b-4cf2-b779-42328831e13e@kdbg.org> cf. <b79a479b-d279-4ac9-a368-6eb8edfed937@kdbg.org> source: <pull.2335.v2.git.git.1784312854.gitgitgadget@gmail.com> |
Contributor
Author
|
/submit |
|
Submitted as pull.2335.v3.git.git.1784538619.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
Junio C Hamano wrote on the Git mailing list (how to reply to this email): "Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Add a --reset-when-found option to git bisect that resets the bisect session
> when culprit is found.
>
> Changes in v3:
>
> * Rename --auto-reset to --reset-when-found, including internal names.
> * Defer git bisect run cleanup until captured output is printed and
> BISECT_RUN is closed. Drop the open-descriptor preparatory change,
> retaining the existing filename-based output handling.
The range-diff looks very busy, but it mostly looks like a fallout
caused by the renaming of the option and internal functions and enum
to match the updated name.
Looking good. Is everybody happy with this version? If so I'll
mark the topic for 'next' soonish.
Thanks. |
|
This branch is now known as |
|
This patch series was integrated into next via 1dc394a. |
|
There was a status update in the "Cooking" section about the branch The 'git bisect' command has been taught a '--reset-when-found[=<where>]' option that tells the command to automatically run 'git bisect reset' to jump back to the original state or to the found culprit. Will merge to 'master'. cf. <xmqqldb5d1d9.fsf@gitster.g> source: <pull.2335.v3.git.git.1784538619.gitgitgadget@gmail.com> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
--reset-when-foundoption togit bisectthat resets the bisect session when culprit is found.Changes in v3:
--auto-resetto--reset-when-found, including internal names.git bisect runcleanup until captured output is printed andBISECT_RUNis closed. Drop the open-descriptor preparatory change, retaining the existing filename-based output handling.Changes in v2:
--auto-reset[=<where>]with option to go to final commit as well as original.cc: Johannes Sixt j6t@kdbg.org