Conversation
Member
Author
|
Woot! |
Member
|
Did that work okay for you? |
Member
Author
|
@rtyley pretty well! The only thing I noticed was that the author name was the GitHub handle rather than the real name. We could maybe glean the real name from the sign-off line? |
Member
That was what @jfmc used when they made the commit! If you look at the raw commit, you'll see this: ...if the commit was made through the GitHub web interface editor, the name reflects the fact that @jfmc hasn't set a GitHub profile name. |
Member
Author
|
Good point! Sorry for blaming submitGit for what is clearly not its fault 😏 |
The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix the obvious copy-edit bug. Signed-off-by: Jose F. Morales <jfmcjf@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
This has been merged upstream: c3cb7b6 |
Closed
derrickstolee
added a commit
to derrickstolee/git
that referenced
this pull request
Aug 16, 2019
The parse_commit_no_graph() method was added in 43d3561 ("commit-graph write: don't die if the existing graph is corrupt" 2019-03-25) as a way to avoid persisting bad data across commit-graph files. That is, if the commit-graph file has undetected corrupt data -- such as a flipped bit in a parent int-id value -- then that data will persist to the next commit-graph file. The parse_commit_no_graph() method was used to always use the pack data directly instead. Unfortunately, this comes at a significant performance cost. In both time and memory, parsing from pack files is much slower than parsing from the commit-graph file. In a repository with 4.5 million commits, this can lead to Git taking up to 11gb of memory to rewrite the file. Now that the incremental commit-graph file format exists, we can rely on the quality of the commit-graph file if we follow the two-step pattern of (1) write a commit-graph with "--split" and (2) run "git commit-graph verify --shallow" to verify the tip file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to open and test the second end of the pipe clearly imitates
the code for the first end. A little too closely, though... Let's fix
the obvious copy-edit bug.
Signed-off-by: Jose F. Morales jfmcjf@gmail.com
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de