bugfix: on exception log 500 status code instead of 200 status code#65
Merged
bugfix: on exception log 500 status code instead of 200 status code#65
Conversation
Contributor
pboos
commented
Nov 22, 2023
pboos
commented
- Fix exception handling to report 500 status code instead of 200 status code (done here)
- This required switching to Filter & Interceptor to improve the handling and being able to get the actual exception
- Add integration tests
pboos
changed the title
eleonoraborghi
approved these changes
Nov 22, 2023
eleonoraborghi
left a comment
eleonoraborghi
left a comment
There was a problem hiding this comment.
Not really sure I fully understand all... but the part I do looks good!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.