-
Notifications
You must be signed in to change notification settings - Fork 1
feat: mcp-integration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| from typing import Any | ||
|
|
||
| import sentry_sdk | ||
| from sentry_sdk.integrations.mcp import MCPIntegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The code imports MCPIntegration from sentry_sdk.integrations.mcp, but this class and module do not exist, causing an import error on startup.
(Severity: Critical 0.90 | Confidence: 0.98)
🔍 Detailed Analysis
The code attempts to import MCPIntegration from sentry_sdk.integrations.mcp in test-mcp/main_lowlevel.py, test-mcp/main_fastmcp.py, and test-mcp/main.py. However, neither the MCPIntegration class nor the sentry_sdk.integrations.mcp module exists in the accessible codebase. Executing any of these scripts will raise an ImportError or ModuleNotFoundError, which will prevent the application from starting.
💡 Suggested Fix
Implement the MCPIntegration class within the sentry-python SDK. Alternatively, remove the test files that import this non-existent class until the implementation is available.
🤖 Prompt for AI Agent
Fix this bug. In test-mcp/main_lowlevel.py at line 19: The code attempts to import
`MCPIntegration` from `sentry_sdk.integrations.mcp` in `test-mcp/main_lowlevel.py`,
`test-mcp/main_fastmcp.py`, and `test-mcp/main.py`. However, neither the
`MCPIntegration` class nor the `sentry_sdk.integrations.mcp` module exists in the
accessible codebase. Executing any of these scripts will raise an `ImportError` or
`ModuleNotFoundError`, which will prevent the application from starting.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SDK is not yet released, but this PR assists in releasing it.
sentrivana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻
| - Complex error handling requirements | ||
| - Performance-critical applications | ||
|
|
||
| **See [COMPARISON.md](./COMPARISON.md) for detailed side-by-side code examples.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no COMPARISON.md
Contributes to https://linear.app/getsentry/issue/TET-1267/mcp-python-sdk-integration
Closes https://linear.app/getsentry/issue/TET-1303/python-mcp-check-out-fastmcp