ref(tracing): Restore ability to have tracing disabled#991
Merged
Conversation
lobsterkatie
force-pushed
the
kmclb-reenable-disabling-tracing
branch
from
January 29, 2021 21:38
3ba1a93 to
2327fa7
Compare
RaduW
approved these changes
Feb 1, 2021
This was referenced Mar 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially reverts #948 and 6fc2287, to restore the ability to disable tracing, which allows it to truly be opt-in as per the spec.
Note that this does not change the behavior that PR was made to reinstate - the model wherein the front end makes sampling decisions, the backend has
traces_sample_rateset to0, and the result is that the backend samples according to the front end decision when there is one, but otherwise does not send transactions. (That PR modified a test to test for that exact scenario, and it still passes.)