Skip to content

fix: Change logging integration defaults#93

Merged
untitaker merged 4 commits into
masterfrom
fix/errors-as-events
Sep 29, 2018
Merged

fix: Change logging integration defaults#93
untitaker merged 4 commits into
masterfrom
fix/errors-as-events

Conversation

@untitaker

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

codecov-io commented Sep 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #93 into master will increase coverage by 5.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage    68.4%   73.78%   +5.37%     
==========================================
  Files          24       24              
  Lines        2067     1793     -274     
  Branches      281      280       -1     
==========================================
- Hits         1414     1323      -91     
+ Misses        544      363     -181     
+ Partials      109      107       -2
Impacted Files Coverage Δ
sentry_sdk/integrations/logging.py 91.52% <100%> (+14.38%) ⬆️
sentry_sdk/integrations/sanic.py 0% <0%> (-79.81%) ⬇️
sentry_sdk/integrations/aws_lambda.py 0% <0%> (ø) ⬆️
sentry_sdk/integrations/django.py 89.28% <0%> (+1.92%) ⬆️
sentry_sdk/hub.py 82% <0%> (+2%) ⬆️
sentry_sdk/integrations/flask.py 83.13% <0%> (+2.89%) ⬆️
sentry_sdk/_compat.py 82.6% <0%> (+3.44%) ⬆️
sentry_sdk/worker.py 87.34% <0%> (+4.2%) ⬆️
sentry_sdk/integrations/__init__.py 86.48% <0%> (+8.43%) ⬆️
sentry_sdk/utils.py 72.67% <0%> (+8.64%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2c1be...69eb42f. Read the comment docs.

@untitaker

Copy link
Copy Markdown
Member Author

Blocked on sanic-org/sanic#1332

@untitaker untitaker changed the title fix: Error logs are events [SPLITME] Experiments with porting sentry to this sdk Sep 28, 2018
@untitaker untitaker changed the title [SPLITME] Experiments with porting sentry to this sdk fix: Change logging integration defaults Sep 29, 2018
@untitaker
untitaker merged commit 4eae772 into master Sep 29, 2018
@untitaker
untitaker deleted the fix/errors-as-events branch September 29, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants