feat(tracing): Add sampling context from AWS and GCP#916
Merged
Conversation
untitaker
reviewed
Nov 10, 2020
untitaker
approved these changes
Nov 10, 2020
lobsterkatie
force-pushed
the
kmclb-aws-gcp-sampling-context
branch
from
November 10, 2020 22:33
02eea58 to
fa4bf76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow-up to #863. This adds sampling context from the AWS and GCP integrations.
In addition, this PR includes two changes to support testing of these changes - fixes to the
DictionaryContainingandObjectDescribedBymatchers, and closing of resources opened by tests to suppress unnecessary warnings.